All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Fabio Baltieri <fabio.baltieri@gmail.com>
Cc: Jean Delvare <jdelvare@suse.de>, Lothar Felten <l-felten@ti.com>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (ina2xx) Change register cache to signed
Date: Sun, 08 Jun 2014 20:16:00 +0000	[thread overview]
Message-ID: <20140608201600.GA30953@roeck-us.net> (raw)
In-Reply-To: <1402174021-25857-1-git-send-email-fabio.baltieri@gmail.com>

On Sat, Jun 07, 2014 at 09:47:01PM +0100, Fabio Baltieri wrote:
> All devices supported by the ina2xx driver are bidirectional and reports
> the measured value as a signed 16 bit, but the current driver
> implementation caches the number as an u16, leading to an incorrect sign
> extension when reporting to the userspace in ina2xx_get_value().
> 
> This patch fixes the problem by using a s16 instead, and has been tested
> on an INA219.
> 
> Signed-off-by: Fabio Baltieri <fabio.baltieri@gmail.com>

Applied.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Fabio Baltieri <fabio.baltieri@gmail.com>
Cc: Jean Delvare <jdelvare@suse.de>, Lothar Felten <l-felten@ti.com>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (ina2xx) Change register cache to signed
Date: Sun, 8 Jun 2014 13:16:00 -0700	[thread overview]
Message-ID: <20140608201600.GA30953@roeck-us.net> (raw)
In-Reply-To: <1402174021-25857-1-git-send-email-fabio.baltieri@gmail.com>

On Sat, Jun 07, 2014 at 09:47:01PM +0100, Fabio Baltieri wrote:
> All devices supported by the ina2xx driver are bidirectional and reports
> the measured value as a signed 16 bit, but the current driver
> implementation caches the number as an u16, leading to an incorrect sign
> extension when reporting to the userspace in ina2xx_get_value().
> 
> This patch fixes the problem by using a s16 instead, and has been tested
> on an INA219.
> 
> Signed-off-by: Fabio Baltieri <fabio.baltieri@gmail.com>

Applied.

Thanks,
Guenter

  reply	other threads:[~2014-06-08 20:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-07 20:47 [lm-sensors] [PATCH] hwmon: (ina2xx) Change register cache to signed Fabio Baltieri
2014-06-07 20:47 ` Fabio Baltieri
2014-06-08 20:16 ` Guenter Roeck [this message]
2014-06-08 20:16   ` Guenter Roeck
2014-06-08 20:30   ` [lm-sensors] " Guenter Roeck
2014-06-08 20:30     ` Guenter Roeck
2014-06-08 20:54     ` Fabio Baltieri
2014-06-08 20:54       ` Fabio Baltieri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140608201600.GA30953@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=fabio.baltieri@gmail.com \
    --cc=jdelvare@suse.de \
    --cc=l-felten@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.