All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	devel <devel@driverdev.osuosl.org>,
	SH-Linux <linux-sh@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v2 04/05] staging: board: Initial board staging support
Date: Tue, 10 Jun 2014 01:56:54 +0000	[thread overview]
Message-ID: <20140610015650.GG30874@verge.net.au> (raw)
In-Reply-To: <CANqRtoTLznzU1mJRJMjNgr0pAY8fY__-12qE77Dz97n47FekhQ@mail.gmail.com>

On Fri, Jun 06, 2014 at 09:07:44PM +0900, Magnus Damm wrote:
> On Fri, May 30, 2014 at 8:10 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, May 29, 2014 at 10:27:30PM +0900, Magnus Damm wrote:
> >> Hi Dan,
> >>
> >> On Thu, May 29, 2014 at 10:20 PM, Dan Carpenter
> >> <dan.carpenter@oracle.com> wrote:
> >> > On Thu, May 29, 2014 at 10:17:32PM +0900, Magnus Damm wrote:
> >> >> --- /dev/null
> >> >> +++ work/drivers/staging/board/Kconfig        2014-05-29 21:40:41.000000000 +0900
> >> >> @@ -0,0 +1,7 @@
> >> >> +config STAGING_BOARD
> >> >> +     boolean "Staging Board Support"
> >> >> +     help
> >> >> +       Select to enable per-board staging support code.
> >> >> +
> >> >> +       If in doubt, say N here.
> >> >> +
> >> >
> >> > Actually, you're probably going to need to add a bunch of dependencies
> >> > here or it will break "make randconfig" right away.  Sorry that I forgot
> >> > about this in the first review.
> >>
> >> Good point, thanks for checking. I will have a look at this and add
> >> dependencies to make sure it builds on a wide range of platforms.
> >
> > Hi Magnus,
> >
> > let me know if you would like me to perform some build-testing.
> 
> Hey Simon,
> 
> Thanks for the offer. When you have time, can you please feed V3 into
> your build test setup?
> 
> [PATCH v3 00/05] staging: Emma Mobile USB driver and KZM9D board code V3
> [PATCH v3 01/05] staging: emxx_udc: Add Emma Mobile USB Gadget driver
> [PATCH v3 02/05] staging: emxx_udc: I/O memory and IRQ resource support
> [PATCH v3 03/05] staging: emxx_udc: Add TODO file
> [PATCH v3 04/05] staging: board: Initial board staging support
> [PATCH v3 05/05] staging: board: kzm9d: Board staging support for emxx_udc

Hi Magnus,

my test was less exciting as I had hoped as STAGING is not widely
enabled in defconfigs.

I compiled v3.15-rc8 with the patches above applied using
the defconfigs and allmodconfigs for a wide range of architectures.
The result was that all of the configs that built for v3.15-rc8
also built with your patches applied.

In other words, I did not find a problem.

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	devel <devel@driverdev.osuosl.org>,
	SH-Linux <linux-sh@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v2 04/05] staging: board: Initial board staging support
Date: Tue, 10 Jun 2014 10:56:54 +0900	[thread overview]
Message-ID: <20140610015650.GG30874@verge.net.au> (raw)
In-Reply-To: <CANqRtoTLznzU1mJRJMjNgr0pAY8fY__-12qE77Dz97n47FekhQ@mail.gmail.com>

On Fri, Jun 06, 2014 at 09:07:44PM +0900, Magnus Damm wrote:
> On Fri, May 30, 2014 at 8:10 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, May 29, 2014 at 10:27:30PM +0900, Magnus Damm wrote:
> >> Hi Dan,
> >>
> >> On Thu, May 29, 2014 at 10:20 PM, Dan Carpenter
> >> <dan.carpenter@oracle.com> wrote:
> >> > On Thu, May 29, 2014 at 10:17:32PM +0900, Magnus Damm wrote:
> >> >> --- /dev/null
> >> >> +++ work/drivers/staging/board/Kconfig        2014-05-29 21:40:41.000000000 +0900
> >> >> @@ -0,0 +1,7 @@
> >> >> +config STAGING_BOARD
> >> >> +     boolean "Staging Board Support"
> >> >> +     help
> >> >> +       Select to enable per-board staging support code.
> >> >> +
> >> >> +       If in doubt, say N here.
> >> >> +
> >> >
> >> > Actually, you're probably going to need to add a bunch of dependencies
> >> > here or it will break "make randconfig" right away.  Sorry that I forgot
> >> > about this in the first review.
> >>
> >> Good point, thanks for checking. I will have a look at this and add
> >> dependencies to make sure it builds on a wide range of platforms.
> >
> > Hi Magnus,
> >
> > let me know if you would like me to perform some build-testing.
> 
> Hey Simon,
> 
> Thanks for the offer. When you have time, can you please feed V3 into
> your build test setup?
> 
> [PATCH v3 00/05] staging: Emma Mobile USB driver and KZM9D board code V3
> [PATCH v3 01/05] staging: emxx_udc: Add Emma Mobile USB Gadget driver
> [PATCH v3 02/05] staging: emxx_udc: I/O memory and IRQ resource support
> [PATCH v3 03/05] staging: emxx_udc: Add TODO file
> [PATCH v3 04/05] staging: board: Initial board staging support
> [PATCH v3 05/05] staging: board: kzm9d: Board staging support for emxx_udc

Hi Magnus,

my test was less exciting as I had hoped as STAGING is not widely
enabled in defconfigs.

I compiled v3.15-rc8 with the patches above applied using
the defconfigs and allmodconfigs for a wide range of architectures.
The result was that all of the configs that built for v3.15-rc8
also built with your patches applied.

In other words, I did not find a problem.

  reply	other threads:[~2014-06-10  1:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 13:16 [PATCH v2 00/05] staging: Emma Mobile USB driver and KZM9D board code V2 Magnus Damm
2014-05-29 13:16 ` Magnus Damm
2014-05-29 13:17 ` [PATCH v2 01/05] staging: emxx_udc: Add Emma Mobile USB Gadget driver Magnus Damm
2014-05-29 13:17 ` [PATCH v2 02/05] staging: emxx_udc: I/O memory and IRQ resource support Magnus Damm
2014-05-29 13:17   ` Magnus Damm
2014-05-29 13:17 ` [PATCH v2 03/05] staging: emxx_udc: Add TODO file Magnus Damm
2014-05-29 13:17   ` Magnus Damm
2014-05-29 13:17 ` [PATCH v2 04/05] staging: board: Initial board staging support Magnus Damm
2014-05-29 13:17   ` Magnus Damm
2014-05-29 13:20   ` Dan Carpenter
2014-05-29 13:20     ` Dan Carpenter
2014-05-29 13:27     ` Magnus Damm
2014-05-29 13:27       ` Magnus Damm
2014-05-29 13:53       ` Magnus Damm
2014-05-29 13:53         ` Magnus Damm
2014-05-29 14:03         ` Paul Bolle
2014-05-29 14:03           ` Paul Bolle
2014-05-30  6:23           ` Magnus Damm
2014-05-30  6:23             ` Magnus Damm
2014-05-29 23:10       ` Simon Horman
2014-05-29 23:10         ` Simon Horman
2014-06-06 12:07         ` Magnus Damm
2014-06-06 12:07           ` Magnus Damm
2014-06-10  1:56           ` Simon Horman [this message]
2014-06-10  1:56             ` Simon Horman
2014-05-29 13:17 ` [PATCH v2 05/05] staging: board: kzm9d: Board staging support for emxx_udc Magnus Damm
2014-05-29 13:17   ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140610015650.GG30874@verge.net.au \
    --to=horms@verge.net.au \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.