From: Andy Gross <agross@codeaurora.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Kumar Gala <galak@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [RFC PATCH 1/2] soc: qcom: do not disable the iface clock in probe
Date: Tue, 10 Jun 2014 12:46:56 -0500 [thread overview]
Message-ID: <20140610174656.GA10275@qualcomm.com> (raw)
In-Reply-To: <539742B6.7030303@codeaurora.org>
On Tue, Jun 10, 2014 at 10:39:02AM -0700, Stephen Boyd wrote:
<snip>
> >> diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
> >> index ab7b441..64fb298 100644
> >> --- a/drivers/soc/qcom/qcom_gsbi.c
> >> +++ b/drivers/soc/qcom/qcom_gsbi.c
> >> @@ -22,44 +22,63 @@
> >> #define GSBI_CTRL_REG 0x0000
> >> #define GSBI_PROTOCOL_SHIFT 4
> >>
> >> +struct gsbi_info {
> >> + struct clk *hclk;
> >> + u32 mode;
> >> + u32 crci;
> >> +};
>
> What does mode and crci have to do with this patch? Can't we just put
> the clock into the platform data?
I second this notion.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-06-10 17:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 14:31 [RFC PATCH 0/2] MSM/QCOM: Fix few race conditions when DEBUG_LL is enabled Srinivas Kandagatla
2014-06-10 14:31 ` [RFC PATCH 1/2] soc: qcom: do not disable the iface clock in probe Srinivas Kandagatla
2014-06-10 15:20 ` Kumar Gala
2014-06-10 17:39 ` Stephen Boyd
2014-06-10 17:46 ` Andy Gross [this message]
2014-06-10 17:47 ` Srinivas Kandagatla
2014-06-10 17:57 ` Andy Gross
2014-07-17 20:18 ` Srinivas Kandagatla
2014-08-12 4:25 ` Srinivas Kandagatla
2014-06-10 14:32 ` [RFC PATCH 2/2] tty:msm_serial: Do not reset IP if we use bootconsole Srinivas Kandagatla
2014-06-10 14:37 ` Srinivas Kandagatla
2014-06-17 21:09 ` Stephen Boyd
2014-06-17 22:04 ` Srinivas Kandagatla
2014-07-10 13:38 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610174656.GA10275@qualcomm.com \
--to=agross@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.