* [patch] amd-xgbe: unwind on error in xgbe_mdio_register()
@ 2014-06-11 6:56 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2014-06-11 6:56 UTC (permalink / raw)
To: Tom Lendacky; +Cc: netdev, kernel-janitors
There is a typo here so we return directly instead of unwinding.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
index 52bbdbf..ea7a5d6 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
@@ -367,7 +367,7 @@ int xgbe_mdio_register(struct xgbe_prv_data *pdata)
if (!phydev->drv || (phydev->drv->phy_id = 0)) {
netdev_err(netdev, "phy_id not valid\n");
- return -ENODEV;
+ ret = -ENODEV;
goto err_phy_connect;
}
DBGPR(" phy_connect_direct succeeded for PHY %s, link=%d\n",
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] amd-xgbe: unwind on error in xgbe_mdio_register()
@ 2014-06-11 6:56 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2014-06-11 6:56 UTC (permalink / raw)
To: Tom Lendacky; +Cc: netdev, kernel-janitors
There is a typo here so we return directly instead of unwinding.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
index 52bbdbf..ea7a5d6 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
@@ -367,7 +367,7 @@ int xgbe_mdio_register(struct xgbe_prv_data *pdata)
if (!phydev->drv || (phydev->drv->phy_id == 0)) {
netdev_err(netdev, "phy_id not valid\n");
- return -ENODEV;
+ ret = -ENODEV;
goto err_phy_connect;
}
DBGPR(" phy_connect_direct succeeded for PHY %s, link=%d\n",
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] amd-xgbe: unwind on error in xgbe_mdio_register()
2014-06-11 6:56 ` Dan Carpenter
@ 2014-06-11 13:15 ` Tom Lendacky
-1 siblings, 0 replies; 6+ messages in thread
From: Tom Lendacky @ 2014-06-11 13:15 UTC (permalink / raw)
To: Dan Carpenter; +Cc: netdev, kernel-janitors
On 06/11/2014 01:56 AM, Dan Carpenter wrote:
> There is a typo here so we return directly instead of unwinding.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> index 52bbdbf..ea7a5d6 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> @@ -367,7 +367,7 @@ int xgbe_mdio_register(struct xgbe_prv_data *pdata)
>
> if (!phydev->drv || (phydev->drv->phy_id = 0)) {
> netdev_err(netdev, "phy_id not valid\n");
> - return -ENODEV;
> + ret = -ENODEV;
> goto err_phy_connect;
> }
> DBGPR(" phy_connect_direct succeeded for PHY %s, link=%d\n",
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] amd-xgbe: unwind on error in xgbe_mdio_register()
@ 2014-06-11 13:15 ` Tom Lendacky
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lendacky @ 2014-06-11 13:15 UTC (permalink / raw)
To: Dan Carpenter; +Cc: netdev, kernel-janitors
On 06/11/2014 01:56 AM, Dan Carpenter wrote:
> There is a typo here so we return directly instead of unwinding.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> index 52bbdbf..ea7a5d6 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> @@ -367,7 +367,7 @@ int xgbe_mdio_register(struct xgbe_prv_data *pdata)
>
> if (!phydev->drv || (phydev->drv->phy_id == 0)) {
> netdev_err(netdev, "phy_id not valid\n");
> - return -ENODEV;
> + ret = -ENODEV;
> goto err_phy_connect;
> }
> DBGPR(" phy_connect_direct succeeded for PHY %s, link=%d\n",
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] amd-xgbe: unwind on error in xgbe_mdio_register()
2014-06-11 6:56 ` Dan Carpenter
@ 2014-06-11 22:40 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2014-06-11 22:40 UTC (permalink / raw)
To: dan.carpenter; +Cc: thomas.lendacky, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 11 Jun 2014 09:56:26 +0300
> There is a typo here so we return directly instead of unwinding.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-11 22:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-11 6:56 [patch] amd-xgbe: unwind on error in xgbe_mdio_register() Dan Carpenter
2014-06-11 6:56 ` Dan Carpenter
2014-06-11 13:15 ` Tom Lendacky
2014-06-11 13:15 ` Tom Lendacky
2014-06-11 22:40 ` David Miller
2014-06-11 22:40 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.