From: Luiz Capitulino <lcapitulino@redhat.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Christoph Lameter <cl@linux-foundation.org>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>, Rik van Riel <riel@redhat.com>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] x86: numa: drop ZONE_ALIGN
Date: Wed, 11 Jun 2014 09:23:37 -0400 [thread overview]
Message-ID: <20140611092337.35794bc0@redhat.com> (raw)
In-Reply-To: <CAE9FiQUWZxvCS82cH=n-NF+nhTQ83J+7M3gHdXGu2S1Qk3xL_g@mail.gmail.com>
Yinghai, sorry for my late reply.
On Mon, 9 Jun 2014 15:13:41 -0700
Yinghai Lu <yinghai@kernel.org> wrote:
> On Mon, Jun 9, 2014 at 12:03 PM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> > On Sun, 8 Jun 2014 18:29:11 -0700
> > Yinghai Lu <yinghai@kernel.org> wrote:
> >
> >> On Sun, Jun 8, 2014 at 3:14 PM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> > [ 0.000000] e820: BIOS-provided physical RAM map:
> > [ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000009fbff] usable
> > [ 0.000000] BIOS-e820: [mem 0x000000000009fc00-0x000000000009ffff] reserved
> > [ 0.000000] BIOS-e820: [mem 0x00000000000e0000-0x00000000000fffff] reserved
> > [ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x000000003ffeffff] usable
> > [ 0.000000] BIOS-e820: [mem 0x000000003fff0000-0x000000003fffefff] ACPI data
> > [ 0.000000] BIOS-e820: [mem 0x000000003ffff000-0x000000003fffffff] ACPI NVS
> > [ 0.000000] BIOS-e820: [mem 0x0000000040200000-0x00000000801fffff] usable
> ...
> > [ 0.000000] SRAT: PXM 0 -> APIC 0x00 -> Node 0
> > [ 0.000000] SRAT: PXM 0 -> APIC 0x01 -> Node 0
> > [ 0.000000] SRAT: PXM 1 -> APIC 0x02 -> Node 1
> > [ 0.000000] SRAT: PXM 1 -> APIC 0x03 -> Node 1
> > [ 0.000000] SRAT: Node 0 PXM 0 [mem 0x00000000-0x3fffffff]
> > [ 0.000000] SRAT: Node 1 PXM 1 [mem 0x40200000-0x801fffff]
> > [ 0.000000] Initmem setup node 0 [mem 0x00000000-0x3fffffff]
> > [ 0.000000] NODE_DATA [mem 0x3ffec000-0x3ffeffff]
> > [ 0.000000] Initmem setup node 1 [mem 0x40800000-0x801fffff]
> > [ 0.000000] NODE_DATA [mem 0x801fb000-0x801fefff]
>
> so node1 start is aligned to 8M from 2M
>
> node0: [0, 1G)
> node1: [1G+2M, 2G+2M)
>
> The zone should not cross the 8M boundary?
Yes, but the question is: why?
> In the case should we trim the memblock for numa to be 8M alignment ?
My current thinking, after discussing this with David, is to just page
align the memory range. This should fix the hyperv-triggered bug in 2.6.32
and seems to be the right thing for upstream too.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Christoph Lameter <cl@linux-foundation.org>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>, Rik van Riel <riel@redhat.com>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] x86: numa: drop ZONE_ALIGN
Date: Wed, 11 Jun 2014 09:23:37 -0400 [thread overview]
Message-ID: <20140611092337.35794bc0@redhat.com> (raw)
In-Reply-To: <CAE9FiQUWZxvCS82cH=n-NF+nhTQ83J+7M3gHdXGu2S1Qk3xL_g@mail.gmail.com>
Yinghai, sorry for my late reply.
On Mon, 9 Jun 2014 15:13:41 -0700
Yinghai Lu <yinghai@kernel.org> wrote:
> On Mon, Jun 9, 2014 at 12:03 PM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> > On Sun, 8 Jun 2014 18:29:11 -0700
> > Yinghai Lu <yinghai@kernel.org> wrote:
> >
> >> On Sun, Jun 8, 2014 at 3:14 PM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> > [ 0.000000] e820: BIOS-provided physical RAM map:
> > [ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000009fbff] usable
> > [ 0.000000] BIOS-e820: [mem 0x000000000009fc00-0x000000000009ffff] reserved
> > [ 0.000000] BIOS-e820: [mem 0x00000000000e0000-0x00000000000fffff] reserved
> > [ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x000000003ffeffff] usable
> > [ 0.000000] BIOS-e820: [mem 0x000000003fff0000-0x000000003fffefff] ACPI data
> > [ 0.000000] BIOS-e820: [mem 0x000000003ffff000-0x000000003fffffff] ACPI NVS
> > [ 0.000000] BIOS-e820: [mem 0x0000000040200000-0x00000000801fffff] usable
> ...
> > [ 0.000000] SRAT: PXM 0 -> APIC 0x00 -> Node 0
> > [ 0.000000] SRAT: PXM 0 -> APIC 0x01 -> Node 0
> > [ 0.000000] SRAT: PXM 1 -> APIC 0x02 -> Node 1
> > [ 0.000000] SRAT: PXM 1 -> APIC 0x03 -> Node 1
> > [ 0.000000] SRAT: Node 0 PXM 0 [mem 0x00000000-0x3fffffff]
> > [ 0.000000] SRAT: Node 1 PXM 1 [mem 0x40200000-0x801fffff]
> > [ 0.000000] Initmem setup node 0 [mem 0x00000000-0x3fffffff]
> > [ 0.000000] NODE_DATA [mem 0x3ffec000-0x3ffeffff]
> > [ 0.000000] Initmem setup node 1 [mem 0x40800000-0x801fffff]
> > [ 0.000000] NODE_DATA [mem 0x801fb000-0x801fefff]
>
> so node1 start is aligned to 8M from 2M
>
> node0: [0, 1G)
> node1: [1G+2M, 2G+2M)
>
> The zone should not cross the 8M boundary?
Yes, but the question is: why?
> In the case should we trim the memblock for numa to be 8M alignment ?
My current thinking, after discussing this with David, is to just page
align the memory range. This should fix the hyperv-triggered bug in 2.6.32
and seems to be the right thing for upstream too.
next prev parent reply other threads:[~2014-06-11 13:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-08 22:14 [PATCH] x86: numa: drop ZONE_ALIGN Luiz Capitulino
2014-06-08 22:14 ` Luiz Capitulino
2014-06-08 22:25 ` David Rientjes
2014-06-08 22:25 ` David Rientjes
2014-06-09 18:43 ` Luiz Capitulino
2014-06-09 18:43 ` Luiz Capitulino
2014-06-09 21:57 ` David Rientjes
2014-06-09 21:57 ` David Rientjes
2014-06-10 3:19 ` Luiz Capitulino
2014-06-10 3:19 ` Luiz Capitulino
2014-06-10 22:10 ` David Rientjes
2014-06-10 22:10 ` David Rientjes
2014-06-11 2:21 ` Luiz Capitulino
2014-06-11 2:21 ` Luiz Capitulino
2014-06-09 1:29 ` Yinghai Lu
2014-06-09 1:29 ` Yinghai Lu
2014-06-09 19:03 ` Luiz Capitulino
2014-06-09 19:03 ` Luiz Capitulino
2014-06-09 22:13 ` Yinghai Lu
2014-06-09 22:13 ` Yinghai Lu
2014-06-11 13:23 ` Luiz Capitulino [this message]
2014-06-11 13:23 ` Luiz Capitulino
2014-06-11 13:58 ` Christoph Lameter
2014-06-11 13:58 ` Christoph Lameter
2014-06-11 22:54 ` David Rientjes
2014-06-11 22:54 ` David Rientjes
2014-06-13 15:47 ` Christoph Lameter
2014-06-13 15:47 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611092337.35794bc0@redhat.com \
--to=lcapitulino@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.