All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
	linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Finn Thain <fthain@telegraphics.com.au>,
	Michael Schmitz <schmitzmic@gmail.com>
Subject: Re: [PATCH 2/4] [SCSI] pas16: don't call free_dma()
Date: Wed, 11 Jun 2014 05:17:27 -0700	[thread overview]
Message-ID: <20140611121727.GC8389@infradead.org> (raw)
In-Reply-To: <1402003789-1990031-3-git-send-email-arnd@arndb.de>

On Thu, Jun 05, 2014 at 11:29:47PM +0200, Arnd Bergmann wrote:
> The pas16 scsi driver does not use DMA, and the call to free_dma()
> in its exit function seems to have been copied incorrectly from
> another driver but never caused trouble.
> 
> One case where it gets in the way is randconfig builds on ARM,
> which depending on the configuration does not provide a free_dma()
> function, causing this build error:

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] [SCSI] pas16: don't call free_dma()
Date: Wed, 11 Jun 2014 05:17:27 -0700	[thread overview]
Message-ID: <20140611121727.GC8389@infradead.org> (raw)
In-Reply-To: <1402003789-1990031-3-git-send-email-arnd@arndb.de>

On Thu, Jun 05, 2014 at 11:29:47PM +0200, Arnd Bergmann wrote:
> The pas16 scsi driver does not use DMA, and the call to free_dma()
> in its exit function seems to have been copied incorrectly from
> another driver but never caused trouble.
> 
> One case where it gets in the way is randconfig builds on ARM,
> which depending on the configuration does not provide a free_dma()
> function, causing this build error:

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2014-06-11 12:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 21:29 [PATCH 0/4] ARM randconfig fixes for SCSI Arnd Bergmann
2014-06-05 21:29 ` Arnd Bergmann
2014-06-05 21:29 ` [PATCH 1/4] [SCSI] Don't build AdvanSys on ARM Arnd Bergmann
2014-06-05 21:29   ` Arnd Bergmann
2014-06-11 12:17   ` Christoph Hellwig
2014-06-11 12:17     ` Christoph Hellwig
2014-06-05 21:29 ` [PATCH 2/4] [SCSI] pas16: don't call free_dma() Arnd Bergmann
2014-06-05 21:29   ` Arnd Bergmann
2014-06-11 12:17   ` Christoph Hellwig [this message]
2014-06-11 12:17     ` Christoph Hellwig
2014-06-05 21:29 ` [PATCH 3/4] [SCSI] qlogicfas: " Arnd Bergmann
2014-06-05 21:29   ` Arnd Bergmann
2014-06-11 12:17   ` Christoph Hellwig
2014-06-11 12:17     ` Christoph Hellwig
2014-06-05 21:29 ` [PATCH 4/4] [SCSI] NCR53c406a: don't call free_dma() by default Arnd Bergmann
2014-06-05 21:29   ` Arnd Bergmann
2014-06-11 12:17   ` Christoph Hellwig
2014-06-11 12:17     ` Christoph Hellwig
2014-06-25 11:04 ` [PATCH 0/4] ARM randconfig fixes for SCSI Christoph Hellwig
2014-06-25 11:04   ` Christoph Hellwig
2014-06-26  4:11   ` Finn Thain
2014-06-26  4:11     ` Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140611121727.GC8389@infradead.org \
    --to=hch@infradead.org \
    --cc=JBottomley@parallels.com \
    --cc=arnd@arndb.de \
    --cc=fthain@telegraphics.com.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.