From: Christoph Hellwig <hch@infradead.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Steven Haber <steven@qumulo.com>,
linux-scsi@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: SCSI eats error from flush failure during hot plug
Date: Wed, 11 Jun 2014 06:37:36 -0700 [thread overview]
Message-ID: <20140611133736.GA12240@infradead.org> (raw)
In-Reply-To: <1402334946.2197.17.camel@dabdike.int.hansenpartnership.com>
On Mon, Jun 09, 2014 at 10:29:06AM -0700, James Bottomley wrote:
> I'll do it as a bug fix, but I do need Jens to make sure nothing else
> breaks first. Best I can tell, the state model for compound commands
> like flush doesn't expect us to change the request type ... nothing puts
> it back to REQ_TYPE_FS. In your case, the flush is the last command
> sent, so there's no problem ... I just worry we will get an obscure
> problem later on from something that does a BLOCK_PC prepared first
> command.
Yes, I don't think resetting cmd_type is a good idea. I'd much rather
see a special case for rq->cmd_flags & REQ_FLUSH in the completion
handler - we already treat it special during setup anyway.
next prev parent reply other threads:[~2014-06-11 13:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 23:52 SCSI eats error from flush failure during hot plug Steven Haber
2014-06-07 19:29 ` James Bottomley
2014-06-09 17:21 ` Steven Haber
2014-06-09 17:29 ` James Bottomley
2014-06-11 13:37 ` Christoph Hellwig [this message]
2014-06-19 18:05 ` James Bottomley
2014-06-25 13:13 ` Christoph Hellwig
2014-06-26 14:02 ` James Bottomley
2014-06-26 15:00 ` Christoph Hellwig
2014-06-26 15:04 ` James Bottomley
2014-06-26 15:08 ` Christoph Hellwig
2014-06-26 18:52 ` James Bottomley
2014-06-27 7:53 ` Christoph Hellwig
2014-06-26 15:02 ` Christoph Hellwig
2014-06-26 18:13 ` Steven Haber
2014-06-26 18:52 ` James Bottomley
2014-06-27 7:55 ` Christoph Hellwig
[not found] ` <CAPK7rjdpxAALA-oLZJ3wDBPc3kr5Nw4jLALLxEaT0zSiAOD+wg@mail.gmail.com>
2014-06-30 18:45 ` Steven Haber
2014-07-01 8:15 ` Christoph Hellwig
2014-07-03 16:57 ` Steven Haber
2014-07-03 17:18 ` Christoph Hellwig
2014-07-09 22:38 ` James Bottomley
2014-07-10 7:44 ` Christoph Hellwig
2014-07-17 15:27 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611133736.GA12240@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=linux-scsi@vger.kernel.org \
--cc=steven@qumulo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.