All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Steven Haber <steven@qumulo.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: SCSI eats error from flush failure during hot plug
Date: Thu, 26 Jun 2014 08:02:08 -0700	[thread overview]
Message-ID: <20140626150208.GA14887@infradead.org> (raw)
In-Reply-To: <CAPK7rjcrBuQgoiAxZ9ZASAGugtyHTsHB3ssZegKtuzRdo9TMNQ@mail.gmail.com>

Hi Steven,

can you test the patch below?

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index f7e3163..9b56e48 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -733,6 +733,14 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
 			scsi_next_command(cmd);
 			return;
 		}
+	} else if (req->cmd_flags & REQ_FLUSH) {
+		/*
+		 * Flush request don't transfer data, so we can't try
+		 * to complete the good bytes first before checking
+		 * the error.
+		 */
+		if (result && !sense_deferred)
+			error = __scsi_error_from_host_byte(cmd, result);
 	}
 
 	/* no bidi support for !REQ_TYPE_BLOCK_PC yet */

  parent reply	other threads:[~2014-06-26 15:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 23:52 SCSI eats error from flush failure during hot plug Steven Haber
2014-06-07 19:29 ` James Bottomley
2014-06-09 17:21   ` Steven Haber
2014-06-09 17:29     ` James Bottomley
2014-06-11 13:37       ` Christoph Hellwig
2014-06-19 18:05         ` James Bottomley
2014-06-25 13:13           ` Christoph Hellwig
2014-06-26 14:02             ` James Bottomley
2014-06-26 15:00               ` Christoph Hellwig
2014-06-26 15:04                 ` James Bottomley
2014-06-26 15:08                   ` Christoph Hellwig
2014-06-26 18:52                     ` James Bottomley
2014-06-27  7:53                       ` Christoph Hellwig
2014-06-26 15:02 ` Christoph Hellwig [this message]
2014-06-26 18:13   ` Steven Haber
2014-06-26 18:52   ` James Bottomley
2014-06-27  7:55     ` Christoph Hellwig
     [not found]       ` <CAPK7rjdpxAALA-oLZJ3wDBPc3kr5Nw4jLALLxEaT0zSiAOD+wg@mail.gmail.com>
2014-06-30 18:45         ` Steven Haber
2014-07-01  8:15           ` Christoph Hellwig
2014-07-03 16:57             ` Steven Haber
2014-07-03 17:18               ` Christoph Hellwig
2014-07-09 22:38                 ` James Bottomley
2014-07-10  7:44                   ` Christoph Hellwig
2014-07-17 15:27                   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140626150208.GA14887@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=steven@qumulo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.