From: Dan Carpenter <dan.carpenter@oracle.com>
To: nick <nickkrause@sympatico.ca>
Cc: martyn.welch@ge.com, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, manohar.vanga@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]
Date: Thu, 12 Jun 2014 18:10:37 +0300 [thread overview]
Message-ID: <20140612151037.GU5500@mwanda> (raw)
In-Reply-To: <BLU436-SMTP2404B87A72E455C1BDE2B43A52A0@phx.gbl>
On Thu, Jun 12, 2014 at 10:33:09AM -0400, nick wrote:
> Here is the fixed patch. Having issues with using Thunderbird
> so just used Evolution for now.
> Nick
Please read the first paragraph of:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt
It's not clear from reading this email why 0 is incorrect and 3<<16 is
correct. Explain in the changelog. What are the user visible effects
of this bug etc.
The patch must have a signed-off-by line.
Here is what typical patch emails should look like:
https://lkml.org/lkml/2014/6/12/377
https://lkml.org/lkml/2014/6/12/369
https://lkml.org/lkml/2014/6/12/299
The subject should be:
[PATCH] vme: ca91cx42: Bad if test something something
Make sure it apply with `git am` and review the log.
regards,
dan carpenter
next prev parent reply other threads:[~2014-06-12 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 14:33 PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix] nick
2014-06-12 15:10 ` Dan Carpenter [this message]
2014-06-12 20:52 ` Dan Carpenter
2014-06-16 9:47 ` Martyn Welch
2014-06-16 9:56 ` Dan Carpenter
2014-06-16 10:08 ` Martyn Welch
[not found] <SNT145-W1D429653B80A40C499048A52A0@phx.gbl>
2014-06-12 5:19 ` PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix] gregkh
-- strict thread matches above, loose matches on Subject: below --
2014-06-12 3:44 PATCH[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix] Nick Krause
2014-06-12 3:53 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612151037.GU5500@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=martyn.welch@ge.com \
--cc=nickkrause@sympatico.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.