From: Dan Carpenter <dan.carpenter@oracle.com>
To: nick <nickkrause@sympatico.ca>
Cc: martyn.welch@ge.com, devel@driverdev.osuosl.org,
manohar.vanga@gmail.com, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]
Date: Thu, 12 Jun 2014 23:52:08 +0300 [thread overview]
Message-ID: <20140612205208.GY5015@mwanda> (raw)
In-Reply-To: <20140612151037.GU5500@mwanda>
Martyn,
Nick Krause emailed me privately that he's not able to get git to work.
Normally for bug fixes, we would patch this up ourselves.
The offending code was introduced in:
commit 2b82beb8c1bc81b3dde69d16cacbc22546681acf
Author: Martyn Welch <martyn.welch@ge.com>
Date: Thu Feb 18 15:13:19 2010 +0000
Staging: vme: Add location monitor support for ca91cx42
The |= 0 does look very suspicious and I have a static checker warning
for code like that. Certainly it sounds very authoritative to say that
instead of zero, CA91CX42_LM_CTL_AS_A16 should be (3 << 16). But then
the condition:
if ((lm_ctl & (5 << 16)) == (3 << 16))
is always false... It is puzzling.
I don't know this code and I have no idea what is correct. Was this a
real bug that Nick hit in testing, or was it a static checker fix? He
hasn't told us any of this stuff...
What to do...
regards,
dan carpenter
next prev parent reply other threads:[~2014-06-12 20:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 14:33 PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix] nick
2014-06-12 15:10 ` Dan Carpenter
2014-06-12 20:52 ` Dan Carpenter [this message]
2014-06-16 9:47 ` Martyn Welch
2014-06-16 9:56 ` Dan Carpenter
2014-06-16 10:08 ` Martyn Welch
[not found] <SNT145-W1D429653B80A40C499048A52A0@phx.gbl>
2014-06-12 5:19 ` PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix] gregkh
-- strict thread matches above, loose matches on Subject: below --
2014-06-12 3:44 PATCH[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix] Nick Krause
2014-06-12 3:53 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612205208.GY5015@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=martyn.welch@ge.com \
--cc=nickkrause@sympatico.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.