* [PATCH] i2c: sun6-p2wi: fix erroneous error message [not found] <53994cdd.dj2lZ0lrPyPuIr9Z%fengguang.wu@intel.com> @ 2014-06-12 7:32 ` Boris BREZILLON 0 siblings, 0 replies; 4+ messages in thread From: Boris BREZILLON @ 2014-06-12 7:32 UTC (permalink / raw) To: kbuild test robot, Wolfram Sang Cc: Maxime Ripard, Shuge, kevin-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-i2c-u79uwXL29TY76Z2rM5mHXA, Boris BREZILLON The variable containing the return value of platform_get_irq is irq not ret, this means the error code printed in the error message will be false. Signed-off-by: Boris BREZILLON <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Reported-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> --- Hello Wolfram, This patch fixes a bug reported by Fengguang's build robot. I know you've already applied my series to your for-next tree, but let me know if you want me to squash this patch into the P2WI series and send a v8. Best Regards, Boris drivers/i2c/busses/i2c-sun6i-p2wi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c index f1d3e6f..5d2d678 100644 --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c @@ -240,7 +240,7 @@ static int p2wi_probe(struct platform_device *pdev) snprintf(p2wi->adapter.name, sizeof(p2wi->adapter.name), pdev->name); irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(dev, "failed to retrieve irq: %d\n", ret); + dev_err(dev, "failed to retrieve irq: %d\n", irq); return irq; } -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] i2c: sun6-p2wi: fix erroneous error message @ 2014-06-12 7:32 ` Boris BREZILLON 0 siblings, 0 replies; 4+ messages in thread From: Boris BREZILLON @ 2014-06-12 7:32 UTC (permalink / raw) To: linux-arm-kernel The variable containing the return value of platform_get_irq is irq not ret, this means the error code printed in the error message will be false. Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com> Reported-by: Fengguang Wu <fengguang.wu@intel.com> --- Hello Wolfram, This patch fixes a bug reported by Fengguang's build robot. I know you've already applied my series to your for-next tree, but let me know if you want me to squash this patch into the P2WI series and send a v8. Best Regards, Boris drivers/i2c/busses/i2c-sun6i-p2wi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c index f1d3e6f..5d2d678 100644 --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c @@ -240,7 +240,7 @@ static int p2wi_probe(struct platform_device *pdev) snprintf(p2wi->adapter.name, sizeof(p2wi->adapter.name), pdev->name); irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(dev, "failed to retrieve irq: %d\n", ret); + dev_err(dev, "failed to retrieve irq: %d\n", irq); return irq; } -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <1402558321-18981-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH] i2c: sun6-p2wi: fix erroneous error message 2014-06-12 7:32 ` Boris BREZILLON @ 2014-06-12 20:17 ` Wolfram Sang -1 siblings, 0 replies; 4+ messages in thread From: Wolfram Sang @ 2014-06-12 20:17 UTC (permalink / raw) To: Boris BREZILLON Cc: kbuild test robot, Maxime Ripard, Shuge, kevin-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-i2c-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 260 bytes --] > I know you've already applied my series to your for-next tree, but let me > know if you want me to squash this patch into the P2WI series and send a v8. I can't rebase my for-next. Had it already fixed locally, just forgot to send out due to NMI. Thanks. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] i2c: sun6-p2wi: fix erroneous error message @ 2014-06-12 20:17 ` Wolfram Sang 0 siblings, 0 replies; 4+ messages in thread From: Wolfram Sang @ 2014-06-12 20:17 UTC (permalink / raw) To: linux-arm-kernel > I know you've already applied my series to your for-next tree, but let me > know if you want me to squash this patch into the P2WI series and send a v8. I can't rebase my for-next. Had it already fixed locally, just forgot to send out due to NMI. Thanks. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140612/3a5f58ae/attachment.sig> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-12 20:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <53994cdd.dj2lZ0lrPyPuIr9Z%fengguang.wu@intel.com>
[not found] ` <53994cdd.dj2lZ0lrPyPuIr9Z%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-12 7:32 ` [PATCH] i2c: sun6-p2wi: fix erroneous error message Boris BREZILLON
2014-06-12 7:32 ` Boris BREZILLON
[not found] ` <1402558321-18981-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-06-12 20:17 ` Wolfram Sang
2014-06-12 20:17 ` Wolfram Sang
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.