From: Andrew Morton <akpm@linux-foundation.org>
To: Chen Yucong <slaoub@gmail.com>
Cc: mgorman@suse.de, hannes@cmpxchg.org, mhocko@suse.cz,
riel@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/vmscan.c: wrap five parameters into shrink_result for reducing the stack consumption
Date: Thu, 12 Jun 2014 21:40:16 -0700 [thread overview]
Message-ID: <20140612214016.1beda952.akpm@linux-foundation.org> (raw)
In-Reply-To: <1402634191-3442-1-git-send-email-slaoub@gmail.com>
On Fri, 13 Jun 2014 12:36:31 +0800 Chen Yucong <slaoub@gmail.com> wrote:
> @@ -1148,7 +1146,8 @@ unsigned long reclaim_clean_pages_from_list(struct zone *zone,
> .priority = DEF_PRIORITY,
> .may_unmap = 1,
> };
> - unsigned long ret, dummy1, dummy2, dummy3, dummy4, dummy5;
> + unsigned long ret;
> + struct shrink_result dummy = { };
You didn't like the idea of making this static?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Chen Yucong <slaoub@gmail.com>
Cc: mgorman@suse.de, hannes@cmpxchg.org, mhocko@suse.cz,
riel@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/vmscan.c: wrap five parameters into shrink_result for reducing the stack consumption
Date: Thu, 12 Jun 2014 21:40:16 -0700 [thread overview]
Message-ID: <20140612214016.1beda952.akpm@linux-foundation.org> (raw)
In-Reply-To: <1402634191-3442-1-git-send-email-slaoub@gmail.com>
On Fri, 13 Jun 2014 12:36:31 +0800 Chen Yucong <slaoub@gmail.com> wrote:
> @@ -1148,7 +1146,8 @@ unsigned long reclaim_clean_pages_from_list(struct zone *zone,
> .priority = DEF_PRIORITY,
> .may_unmap = 1,
> };
> - unsigned long ret, dummy1, dummy2, dummy3, dummy4, dummy5;
> + unsigned long ret;
> + struct shrink_result dummy = { };
You didn't like the idea of making this static?
next prev parent reply other threads:[~2014-06-13 4:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 4:36 [PATCH v2] mm/vmscan.c: wrap five parameters into shrink_result for reducing the stack consumption Chen Yucong
2014-06-13 4:36 ` Chen Yucong
2014-06-13 4:40 ` Andrew Morton [this message]
2014-06-13 4:40 ` Andrew Morton
2014-06-13 5:21 ` Chen Yucong
2014-06-13 5:21 ` Chen Yucong
2014-06-13 16:28 ` Johannes Weiner
2014-06-13 16:28 ` Johannes Weiner
2014-06-14 3:04 ` Chen Yucong
2014-06-14 3:04 ` Chen Yucong
2014-06-13 4:52 ` Konstantin Khlebnikov
2014-06-13 4:52 ` Konstantin Khlebnikov
2014-06-13 5:21 ` Johannes Weiner
2014-06-13 5:21 ` Johannes Weiner
2014-06-13 10:21 ` Konstantin Khlebnikov
2014-06-13 10:21 ` Konstantin Khlebnikov
2014-06-13 5:10 ` Johannes Weiner
2014-06-13 5:10 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612214016.1beda952.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=slaoub@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.