From: Jeff King <peff@peff.net>
To: Caleb Thompson <caleb@calebthompson.io>
Cc: git@vger.kernel.org, Jeremiah Mahler <jmmahler@gmail.com>,
Duy Nguyen <pclouds@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Johannes Sixt <j.sixt@viscovery.net>, David Kastrup <dak@gnu.org>,
Junio C Hamano <gitster@pobox.com>,
Mike Burns <mike@mike-burns.com>
Subject: Re: [PATCH v5 2/4] commit test: Use write_script
Date: Fri, 13 Jun 2014 19:28:42 -0400 [thread overview]
Message-ID: <20140613232841.GC23078@sigill> (raw)
In-Reply-To: <20140613162607.GA85151@sirius.local>
On Fri, Jun 13, 2014 at 11:26:07AM -0500, Caleb Thompson wrote:
> You're very right - I may have confused this commit message and the one
> to switch to test_set_editor. I'll rewrite this commit message.
>
> What do you think of something like this for the description:
>
> Use write_script from t/test-lib-functions.sh instead of cat,
> shebang, and chmod. This aids in readability for creating the script
> by using the named function and allows us to turn off interpolation
> in the heredoc of the script body to avoid extra escaping, since
> $SHELL_PATH is handled for us.
That looks fine to me. Thanks.
-Peff
next prev parent reply other threads:[~2014-06-13 23:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 19:38 [PATCH v5 0/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-12 19:38 ` [PATCH v5 1/4] commit test: Use test_config instead of git-config Caleb Thompson
2014-06-12 19:39 ` [PATCH v5 2/4] commit test: Use write_script Caleb Thompson
2014-06-13 6:50 ` Jeff King
2014-06-13 16:26 ` Caleb Thompson
2014-06-13 23:28 ` Jeff King [this message]
2014-06-12 19:39 ` [PATCH v5 3/4] commit test: test_set_editor in each test Caleb Thompson
2014-06-13 6:59 ` Jeff King
2014-06-13 16:36 ` Caleb Thompson
2014-06-13 17:16 ` Jakub Narębski
2014-06-13 17:47 ` Caleb Thompson
2014-06-13 18:52 ` Jakub Narębski
2014-06-13 23:39 ` Jeff King
2014-06-13 17:42 ` Junio C Hamano
2014-06-13 23:41 ` Jeff King
2014-06-16 17:46 ` Caleb Thompson
2014-06-16 18:58 ` Junio C Hamano
2014-06-12 20:00 ` [PATCH v5 4/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-13 17:48 ` Junio C Hamano
2014-06-16 19:50 ` Caleb Thompson
2014-06-16 20:05 ` Caleb Thompson
2014-06-16 20:06 ` Junio C Hamano
2014-06-16 20:10 ` Caleb Thompson
2014-06-16 22:25 ` Junio C Hamano
2014-06-12 20:30 ` [PATCH v5 0/4] " Jeremiah Mahler
2014-06-13 16:49 ` Caleb Thompson
2014-06-14 4:14 ` Jeremiah Mahler
2014-06-16 20:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613232841.GC23078@sigill \
--to=peff@peff.net \
--cc=caleb@calebthompson.io \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=jmmahler@gmail.com \
--cc=mike@mike-burns.com \
--cc=pclouds@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.