From: Jeff King <peff@peff.net>
To: Caleb Thompson <caleb@calebthompson.io>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v5 3/4] commit test: test_set_editor in each test
Date: Fri, 13 Jun 2014 19:39:59 -0400 [thread overview]
Message-ID: <20140613233958.GD23078@sigill> (raw)
In-Reply-To: <20140613163644.GB85151@sirius.local>
On Fri, Jun 13, 2014 at 11:36:44AM -0500, Caleb Thompson wrote:
> > Or did you just mean that the new rule is "every test sets the editor as
> > they need", which means that we do not have to worry anymore about
> > polluting the environment for other tests?
>
> That's exactly what I meant. We can stop relying on the global state *as
> it is initially set* and instead move the setup into the tests which
> rely on it.
Ah, OK, it was just me mis-reading, then.
The rewording you included below is clearer to me. Thanks.
> > [1] It might make sense for test_set_editor, when run from within a
> > test, to behave more like test_config, and do:
> >
> > test_when_finished '
> > sane_unset FAKE_EDITOR &&
> > sane_unset EDITOR
> > '
>
> It might, but it's a little out of scope in addition to your concern
> about other test scripts.
Yeah, I agree it does not need to block this series.
-Peff
next prev parent reply other threads:[~2014-06-13 23:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 19:38 [PATCH v5 0/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-12 19:38 ` [PATCH v5 1/4] commit test: Use test_config instead of git-config Caleb Thompson
2014-06-12 19:39 ` [PATCH v5 2/4] commit test: Use write_script Caleb Thompson
2014-06-13 6:50 ` Jeff King
2014-06-13 16:26 ` Caleb Thompson
2014-06-13 23:28 ` Jeff King
2014-06-12 19:39 ` [PATCH v5 3/4] commit test: test_set_editor in each test Caleb Thompson
2014-06-13 6:59 ` Jeff King
2014-06-13 16:36 ` Caleb Thompson
2014-06-13 17:16 ` Jakub Narębski
2014-06-13 17:47 ` Caleb Thompson
2014-06-13 18:52 ` Jakub Narębski
2014-06-13 23:39 ` Jeff King [this message]
2014-06-13 17:42 ` Junio C Hamano
2014-06-13 23:41 ` Jeff King
2014-06-16 17:46 ` Caleb Thompson
2014-06-16 18:58 ` Junio C Hamano
2014-06-12 20:00 ` [PATCH v5 4/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-13 17:48 ` Junio C Hamano
2014-06-16 19:50 ` Caleb Thompson
2014-06-16 20:05 ` Caleb Thompson
2014-06-16 20:06 ` Junio C Hamano
2014-06-16 20:10 ` Caleb Thompson
2014-06-16 22:25 ` Junio C Hamano
2014-06-12 20:30 ` [PATCH v5 0/4] " Jeremiah Mahler
2014-06-13 16:49 ` Caleb Thompson
2014-06-14 4:14 ` Jeremiah Mahler
2014-06-16 20:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613233958.GD23078@sigill \
--to=peff@peff.net \
--cc=caleb@calebthompson.io \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.