From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Waiman Long <Waiman.Long@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Scott J Norton <scott.norton@hp.com>
Subject: Re: [PATCH] mm, thp: move invariant bug check out of loop in __split_huge_page_map
Date: Mon, 16 Jun 2014 23:49:34 +0300 [thread overview]
Message-ID: <20140616204934.GA14208@node.dhcp.inet.fi> (raw)
In-Reply-To: <1402947348-60655-1-git-send-email-Waiman.Long@hp.com>
On Mon, Jun 16, 2014 at 03:35:48PM -0400, Waiman Long wrote:
> In the __split_huge_page_map() function, the check for
> page_mapcount(page) is invariant within the for loop. Because of the
> fact that the macro is implemented using atomic_read(), the redundant
> check cannot be optimized away by the compiler leading to unnecessary
> read to the page structure.
>
> This patch move the invariant bug check out of the loop so that it
> will be done only once.
Looks okay, but why? Was you able to measure difference?
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Waiman Long <Waiman.Long@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Scott J Norton <scott.norton@hp.com>
Subject: Re: [PATCH] mm, thp: move invariant bug check out of loop in __split_huge_page_map
Date: Mon, 16 Jun 2014 23:49:34 +0300 [thread overview]
Message-ID: <20140616204934.GA14208@node.dhcp.inet.fi> (raw)
In-Reply-To: <1402947348-60655-1-git-send-email-Waiman.Long@hp.com>
On Mon, Jun 16, 2014 at 03:35:48PM -0400, Waiman Long wrote:
> In the __split_huge_page_map() function, the check for
> page_mapcount(page) is invariant within the for loop. Because of the
> fact that the macro is implemented using atomic_read(), the redundant
> check cannot be optimized away by the compiler leading to unnecessary
> read to the page structure.
>
> This patch move the invariant bug check out of the loop so that it
> will be done only once.
Looks okay, but why? Was you able to measure difference?
--
Kirill A. Shutemov
next prev parent reply other threads:[~2014-06-16 20:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 19:35 [PATCH] mm, thp: move invariant bug check out of loop in __split_huge_page_map Waiman Long
2014-06-16 19:35 ` Waiman Long
2014-06-16 20:49 ` Kirill A. Shutemov [this message]
2014-06-16 20:49 ` Kirill A. Shutemov
2014-06-16 20:59 ` Kirill A. Shutemov
2014-06-16 20:59 ` Kirill A. Shutemov
2014-06-17 3:45 ` Waiman Long
2014-06-17 3:45 ` Waiman Long
2014-06-17 7:23 ` Kirill A. Shutemov
2014-06-17 7:23 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616204934.GA14208@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=Waiman.Long@hp.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.