From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, Paul Walmsley <paul@pwsan.com>,
Felipe Balbi <balbi@ti.com>, Rajendra Nayak <rnayak@ti.com>,
linux-arm-kernel@lists.infradead.org,
Archit Taneja <archit@ti.com>,
Sathya Prakash M R <sathyap@ti.com>
Subject: Re: [PATCH v2] ARM: AM43xx: hwmod: add DSS hwmod data
Date: Tue, 17 Jun 2014 02:57:15 -0700 [thread overview]
Message-ID: <20140617095715.GS17845@atomide.com> (raw)
In-Reply-To: <53A00970.3090902@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [140617 02:26]:
> On 17/06/14 11:58, Tony Lindgren wrote:
>
> >> +/* rfbi */
> >
> > I think we're still missing am43x_rfbi_sysc entry though?
> >
> >> +static struct omap_hwmod am43xx_dss_rfbi_hwmod = {
> >> + .name = "dss_rfbi",
> >> + .class = &omap2_rfbi_hwmod_class,
> >> + .clkdm_name = "dss_clkdm",
> >> + .main_clk = "disp_clk",
> >> + .prcm = {
> >> + .omap4 = {
> >> + .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
> >> + },
> >> + },
> >> +};
>
> That should come from omap2/3 hwmod data, as the above references
> omap2_rfbi_hwmod_class. The bits there looked correct for AM43xx to me.
OK looks good to me then:
Acked-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: AM43xx: hwmod: add DSS hwmod data
Date: Tue, 17 Jun 2014 02:57:15 -0700 [thread overview]
Message-ID: <20140617095715.GS17845@atomide.com> (raw)
In-Reply-To: <53A00970.3090902@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [140617 02:26]:
> On 17/06/14 11:58, Tony Lindgren wrote:
>
> >> +/* rfbi */
> >
> > I think we're still missing am43x_rfbi_sysc entry though?
> >
> >> +static struct omap_hwmod am43xx_dss_rfbi_hwmod = {
> >> + .name = "dss_rfbi",
> >> + .class = &omap2_rfbi_hwmod_class,
> >> + .clkdm_name = "dss_clkdm",
> >> + .main_clk = "disp_clk",
> >> + .prcm = {
> >> + .omap4 = {
> >> + .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
> >> + },
> >> + },
> >> +};
>
> That should come from omap2/3 hwmod data, as the above references
> omap2_rfbi_hwmod_class. The bits there looked correct for AM43xx to me.
OK looks good to me then:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2014-06-17 9:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 8:37 [PATCH v2] ARM: AM43xx: hwmod: add DSS hwmod data Tomi Valkeinen
2014-06-17 8:37 ` Tomi Valkeinen
2014-06-17 8:58 ` Tony Lindgren
2014-06-17 8:58 ` Tony Lindgren
2014-06-17 9:25 ` Tomi Valkeinen
2014-06-17 9:25 ` Tomi Valkeinen
2014-06-17 9:57 ` Tony Lindgren [this message]
2014-06-17 9:57 ` Tony Lindgren
2014-06-17 13:16 ` Felipe Balbi
2014-06-17 13:16 ` Felipe Balbi
2014-06-22 20:47 ` Paul Walmsley
2014-06-22 20:47 ` Paul Walmsley
2014-07-22 21:14 ` Paul Walmsley
2014-07-22 21:14 ` Paul Walmsley
2014-07-25 16:53 ` Felipe Balbi
2014-07-25 16:53 ` Felipe Balbi
2014-07-29 11:07 ` Tony Lindgren
2014-07-29 11:07 ` Tony Lindgren
2014-07-30 12:09 ` Tomi Valkeinen
2014-07-30 12:09 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617095715.GS17845@atomide.com \
--to=tony@atomide.com \
--cc=archit@ti.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=sathyap@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.