All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: Jeff Liu <jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 09/24]  drivers/iommu: check actual error on iommu_init
Date: Tue, 17 Jun 2014 12:24:30 -0700	[thread overview]
Message-ID: <20140617192430.GC4628@kroah.com> (raw)
In-Reply-To: <20140617152154.GE31771-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>

On Tue, Jun 17, 2014 at 05:21:54PM +0200, Joerg Roedel wrote:
> On Tue, Jun 17, 2014 at 10:29:19PM +0800, Jeff Liu wrote:
> > From: Jie Liu <jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > 
> > kset_create_and_add() has been fixed to return the actual error
> > code ptr rather than NULL, so update iommu_init() to check the
> > return value via IS_ERR() accordingly.
> > 
> > Cc: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
> > Signed-off-by: Jie Liu <jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> 
> Acked-by: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>

Nope, please do not take this patch, it is not needed and as the kset
call is not changing, it will be incorrect.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Joerg Roedel <joro@8bytes.org>
Cc: Jeff Liu <jeff.liu@oracle.com>,
	iommu@lists.linux-foundation.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 09/24]  drivers/iommu: check actual error on iommu_init
Date: Tue, 17 Jun 2014 12:24:30 -0700	[thread overview]
Message-ID: <20140617192430.GC4628@kroah.com> (raw)
In-Reply-To: <20140617152154.GE31771@8bytes.org>

On Tue, Jun 17, 2014 at 05:21:54PM +0200, Joerg Roedel wrote:
> On Tue, Jun 17, 2014 at 10:29:19PM +0800, Jeff Liu wrote:
> > From: Jie Liu <jeff.liu@oracle.com>
> > 
> > kset_create_and_add() has been fixed to return the actual error
> > code ptr rather than NULL, so update iommu_init() to check the
> > return value via IS_ERR() accordingly.
> > 
> > Cc: Joerg Roedel <joro@8bytes.org>
> > Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> 
> Acked-by: Joerg Roedel <joro@8bytes.org>

Nope, please do not take this patch, it is not needed and as the kset
call is not changing, it will be incorrect.

thanks,

greg k-h

  parent reply	other threads:[~2014-06-17 19:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17 14:29 [PATCH 09/24] drivers/iommu: check actual error on iommu_init Jeff Liu
     [not found] ` <53A050BF.3000101-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-06-17 15:21   ` Joerg Roedel
2014-06-17 15:21     ` Joerg Roedel
     [not found]     ` <20140617152154.GE31771-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-06-17 19:24       ` Greg KH [this message]
2014-06-17 19:24         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140617192430.GC4628@kroah.com \
    --to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.