All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>,
	Ashish Sangwan <a.sangwan@samsung.com>
Subject: Re: [PATCH] ext4: fix COLLAPSE RANGE test failure when bigalloc is enable
Date: Tue, 17 Jun 2014 18:09:00 -0400	[thread overview]
Message-ID: <20140617220900.GJ24890@thunk.org> (raw)
In-Reply-To: <001001cf7fcc$34f3c2c0$9edb4840$@samsung.com>

On Wed, Jun 04, 2014 at 05:08:45PM +0900, Namjae Jeon wrote:
> Blocks in collapse range should be collapsed per cluster unit when bigalloc
> is enable. If bigalloc is not enable, EXT4_CLUSTER_SIZE will be same with
> EXT4_BLOCK_SIZE.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>

Correct me if I'm wrong, but this patch enables COLLAPSE_RANGE when
bigalloc is enabled.  The commit description (and the one-line
summary) should emphasize this.

And I assume you've run a full xfstests auto run with bigalloc and
everything passed?

Thanks,

						- Ted

  parent reply	other threads:[~2014-06-17 22:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04  8:08 [PATCH] ext4: fix COLLAPSE RANGE test failure when bigalloc is enable Namjae Jeon
2014-06-04 13:27 ` Lukáš Czerner
2014-06-05  8:48   ` Namjae Jeon
2014-06-17 22:09 ` Theodore Ts'o [this message]
2014-06-19  4:51   ` Namjae Jeon
2014-07-29 14:47     ` Theodore Ts'o
2014-07-30  4:36       ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140617220900.GJ24890@thunk.org \
    --to=tytso@mit.edu \
    --cc=a.sangwan@samsung.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=namjae.jeon@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.