From: Theodore Ts'o <tytso@mit.edu>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: 'linux-ext4' <linux-ext4@vger.kernel.org>,
'Ashish Sangwan' <a.sangwan@samsung.com>
Subject: Re: [PATCH] ext4: fix COLLAPSE RANGE test failure when bigalloc is enable
Date: Tue, 29 Jul 2014 10:47:16 -0400 [thread overview]
Message-ID: <20140729144716.GC2256@thunk.org> (raw)
In-Reply-To: <003a01cf8b7a$33bd03d0$9b370b70$@samsung.com>
On Thu, Jun 19, 2014 at 01:51:58PM +0900, Namjae Jeon wrote:
> On Wed, Jun 04, 2014 at 05:08:45PM +0900, Namjae Jeon wrote:
> > > Blocks in collapse range should be collapsed per cluster unit when bigalloc
> > > is enable. If bigalloc is not enable, EXT4_CLUSTER_SIZE will be same with
> > > EXT4_BLOCK_SIZE.
> > >
> > > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > > Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
> >
> > Correct me if I'm wrong, but this patch enables COLLAPSE_RANGE when
> > bigalloc is enabled. The commit description (and the one-line
> > summary) should emphasize this.
> Yes, You're right. I will update description.
I don't think I saw an updated description, so I've taken care of
updating the description and applied the patch:
commit 3c17714e61314b101fb9bb671e7191ef1e9e63f3
Author: Namjae Jeon <namjae.jeon@samsung.com>
Date: Tue Jul 29 10:45:31 2014 -0400
ext4: fix COLLAPSE RANGE test for bigalloc file systems
Blocks in collapse range should be collapsed per cluster unit when
bigalloc is enable. If bigalloc is not enable, EXT4_CLUSTER_SIZE will
be same with EXT4_BLOCK_SIZE.
With this bug fixed, patch enables COLLAPSE_RANGE for bigalloc, which
fixes a large number of xfstest failures which use fsx.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
- Ted
next prev parent reply other threads:[~2014-07-29 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 8:08 [PATCH] ext4: fix COLLAPSE RANGE test failure when bigalloc is enable Namjae Jeon
2014-06-04 13:27 ` Lukáš Czerner
2014-06-05 8:48 ` Namjae Jeon
2014-06-17 22:09 ` Theodore Ts'o
2014-06-19 4:51 ` Namjae Jeon
2014-07-29 14:47 ` Theodore Ts'o [this message]
2014-07-30 4:36 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729144716.GC2256@thunk.org \
--to=tytso@mit.edu \
--cc=a.sangwan@samsung.com \
--cc=linux-ext4@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.