From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Jack Miller <jack-jZyo8ZIaZD9AfugRpC6u6w@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/2] Nul string list v2
Date: Wed, 18 Jun 2014 11:25:25 +1000 [thread overview]
Message-ID: <20140618012525.GD29264@voom.redhat.com> (raw)
In-Reply-To: <1402936552-10249-1-git-send-email-jack-jZyo8ZIaZD9AfugRpC6u6w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On Mon, Jun 16, 2014 at 11:35:50AM -0500, Jack Miller wrote:
> - Tweaked patch description to make failing case clearer
> - Added test
>
> I decided to only test the mangled output since realloc was just a more serious
> and obvious symptom of the same problem. I also verified that the pre-patch dtc
> does in fact fail the test.
>
> Let me know if there's anything else that needs to be done.
Sure, couple of nits to pick.
It's preferred to fold fix and testcase into the same patch -
particularly for small fixes like this. Further comment against the
individual patches.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-06-18 1:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 16:35 [PATCH 0/2] Nul string list v2 Jack Miller
[not found] ` <1402936552-10249-1-git-send-email-jack-jZyo8ZIaZD9AfugRpC6u6w@public.gmane.org>
2014-06-16 16:35 ` [PATCH 1/2] Properly handle nul delimited string lists Jack Miller
2014-06-16 16:35 ` [PATCH 2/2] Add embedded nul string list test Jack Miller
[not found] ` <1402936552-10249-3-git-send-email-jack-jZyo8ZIaZD9AfugRpC6u6w@public.gmane.org>
2014-06-18 1:27 ` David Gibson
[not found] ` <20140618012729.GE29264-1s0os16eZneny3qCrzbmXA@public.gmane.org>
2014-06-18 17:35 ` Jack Miller
[not found] ` <20140618173519.GA15740-O8SCTCEbm15XsEFxtoW7CMxtgHpCUUYS@public.gmane.org>
2014-06-19 1:57 ` David Gibson
2014-06-18 1:25 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618012525.GD29264@voom.redhat.com \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jack-jZyo8ZIaZD9AfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.