Re: [PATCH 2/2] Add embedded nul string list test

[Jack Miller <jack-jZyo8ZIaZD9AfugRpC6u6w@public.gmane.org>]

On Wed, Jun 18, 2014 at 11:27:29AM +1000, David Gibson wrote:
> > @@ -310,6 +310,9 @@ dtc_tests () {
> >      run_dtc_test -I dts -O dtb -o dtc_comments-cmp.test.dtb comments-cmp.dts
> >      run_test dtbs_equal_ordered dtc_comments.test.dtb dtc_comments-cmp.test.dtb
> >  
> > +    run_dtc_test -I dts -O dtb -o dtc_nul_string_list.dtb nul_string_list.dts
> 
> dtb files generated by the tests should be named XXX.test.dtb so that
> make clean will clean them up again.

Hmmm, the greater problem here seems to be that I'm including a .dtb that
*isn't* disposable and will be cleaned. Should this test check that the
generated dtb decompiles into "","","" format instead of comparing to a
binary? That seems a little weak as it assumes that the intermediate .dtb is
correct, but I don't know your thoughts on including binaries into your test
directory.

- Jack
--
To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html