From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/7] mfd: axp20x: add AXP221 PMIC support
Date: Wed, 18 Jun 2014 10:28:06 +0100 [thread overview]
Message-ID: <20140618092806.GI23945@lee--X1> (raw)
In-Reply-To: <53A15202.1070908@free-electrons.com>
On Wed, 18 Jun 2014, Boris BREZILLON wrote:
> On 18/06/2014 10:36, Lee Jones wrote:
> > On Tue, 17 Jun 2014, Boris BREZILLON wrote:
> >
> >> Add support for the AXP221 PMIC device to the existing AXP20x driver.
> >>
> >> The AXP221 defines a new set of registers, power supplies and regulators,
> >> but most of the API is similar to the AXP20x ones.
> >> The AXP20x irq chip definition is reused, though some interrupts are not
> >> available in the AXP221.
> >>
> >> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
> >> ---
> >> drivers/mfd/axp20x.c | 64 ++++++++++++++++++++++++++++++++++++++++++----
> >> include/linux/mfd/axp20x.h | 56 ++++++++++++++++++++++++++++++++++++++++
> >> 2 files changed, 115 insertions(+), 5 deletions(-)
> > Looks good to me now.
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >
> > Can this go in independently to the other patches in the set?
>
> Yes, as long as no one define an axp221 node in his DT.
> In this case axp221 regulators would be considered as axp20x ones (which
> might be a bit problematic), because axp20x-regulator driver does not
> test the axp variant before probing its regulators (this test is
> introduced in patch 3).
Then I'd prefer to wait and have the dependencies go in at the same
time.
Mark,
As normal, I'm happy to create a shared branch between us.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Boris BREZILLON
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>,
Shuge <shuge-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org>,
kevin-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org
Subject: Re: [PATCH v4 1/7] mfd: axp20x: add AXP221 PMIC support
Date: Wed, 18 Jun 2014 10:28:06 +0100 [thread overview]
Message-ID: <20140618092806.GI23945@lee--X1> (raw)
In-Reply-To: <53A15202.1070908-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
On Wed, 18 Jun 2014, Boris BREZILLON wrote:
> On 18/06/2014 10:36, Lee Jones wrote:
> > On Tue, 17 Jun 2014, Boris BREZILLON wrote:
> >
> >> Add support for the AXP221 PMIC device to the existing AXP20x driver.
> >>
> >> The AXP221 defines a new set of registers, power supplies and regulators,
> >> but most of the API is similar to the AXP20x ones.
> >> The AXP20x irq chip definition is reused, though some interrupts are not
> >> available in the AXP221.
> >>
> >> Signed-off-by: Boris BREZILLON <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> >> ---
> >> drivers/mfd/axp20x.c | 64 ++++++++++++++++++++++++++++++++++++++++++----
> >> include/linux/mfd/axp20x.h | 56 ++++++++++++++++++++++++++++++++++++++++
> >> 2 files changed, 115 insertions(+), 5 deletions(-)
> > Looks good to me now.
> > Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> >
> > Can this go in independently to the other patches in the set?
>
> Yes, as long as no one define an axp221 node in his DT.
> In this case axp221 regulators would be considered as axp20x ones (which
> might be a bit problematic), because axp20x-regulator driver does not
> test the axp variant before probing its regulators (this test is
> introduced in patch 3).
Then I'd prefer to wait and have the dependencies go in at the same
time.
Mark,
As normal, I'm happy to create a shared branch between us.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Carlo Caione <carlo@caione.org>, Shuge <shuge@allwinnertech.com>,
kevin@allwinnertech.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, dev@linux-sunxi.org
Subject: Re: [PATCH v4 1/7] mfd: axp20x: add AXP221 PMIC support
Date: Wed, 18 Jun 2014 10:28:06 +0100 [thread overview]
Message-ID: <20140618092806.GI23945@lee--X1> (raw)
In-Reply-To: <53A15202.1070908@free-electrons.com>
On Wed, 18 Jun 2014, Boris BREZILLON wrote:
> On 18/06/2014 10:36, Lee Jones wrote:
> > On Tue, 17 Jun 2014, Boris BREZILLON wrote:
> >
> >> Add support for the AXP221 PMIC device to the existing AXP20x driver.
> >>
> >> The AXP221 defines a new set of registers, power supplies and regulators,
> >> but most of the API is similar to the AXP20x ones.
> >> The AXP20x irq chip definition is reused, though some interrupts are not
> >> available in the AXP221.
> >>
> >> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
> >> ---
> >> drivers/mfd/axp20x.c | 64 ++++++++++++++++++++++++++++++++++++++++++----
> >> include/linux/mfd/axp20x.h | 56 ++++++++++++++++++++++++++++++++++++++++
> >> 2 files changed, 115 insertions(+), 5 deletions(-)
> > Looks good to me now.
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >
> > Can this go in independently to the other patches in the set?
>
> Yes, as long as no one define an axp221 node in his DT.
> In this case axp221 regulators would be considered as axp20x ones (which
> might be a bit problematic), because axp20x-regulator driver does not
> test the axp variant before probing its regulators (this test is
> introduced in patch 3).
Then I'd prefer to wait and have the dependencies go in at the same
time.
Mark,
As normal, I'm happy to create a shared branch between us.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-06-18 9:28 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 7:38 [PATCH v4 0/7] mfd: axp20x: add AXP221 PMIC support Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 7:38 ` [PATCH v4 1/7] " Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-18 8:36 ` Lee Jones
2014-06-18 8:36 ` Lee Jones
2014-06-18 8:36 ` Lee Jones
2014-06-18 8:46 ` Boris BREZILLON
2014-06-18 8:46 ` Boris BREZILLON
2014-06-18 8:46 ` Boris BREZILLON
2014-06-18 9:28 ` Lee Jones [this message]
2014-06-18 9:28 ` Lee Jones
2014-06-18 9:28 ` Lee Jones
2014-06-17 7:38 ` [PATCH v4 2/7] regulator: axp20x: prepare support for multiple AXP chip families Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 7:38 ` [PATCH v4 3/7] regulator: axp20x: add support for AXP221 regulators Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 7:38 ` [PATCH v4 4/7] regulator: axp20x: reset probe data before each probe Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 20:44 ` Maxime Ripard
2014-06-17 20:44 ` Maxime Ripard
2014-06-17 20:44 ` Maxime Ripard
2014-06-18 7:11 ` Boris BREZILLON
2014-06-18 7:11 ` Boris BREZILLON
2014-06-18 8:32 ` [linux-sunxi] " Hans de Goede
2014-06-18 8:32 ` Hans de Goede
2014-06-18 8:32 ` Hans de Goede
2014-06-18 12:44 ` Maxime Ripard
2014-06-18 12:44 ` Maxime Ripard
2014-06-18 12:44 ` Maxime Ripard
2014-06-17 7:38 ` [PATCH v4 5/7] regulator: add support for regulator set registration Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 7:38 ` [PATCH v4 6/7] regulator: axp20x: make use of devm_regulator_set_register Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
2014-06-17 20:46 ` Maxime Ripard
2014-06-17 20:46 ` Maxime Ripard
2014-06-17 20:46 ` Maxime Ripard
2014-06-18 7:12 ` Boris BREZILLON
2014-06-18 7:12 ` Boris BREZILLON
2014-06-17 7:38 ` [PATCH v4 7/7] mfd: AXP20x: add "x-powers, axp221" compatible string to DT bindings doc Boris BREZILLON
2014-06-17 7:38 ` [PATCH v4 7/7] mfd: AXP20x: add "x-powers,axp221" " Boris BREZILLON
2014-06-17 7:38 ` Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618092806.GI23945@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.