Re: [PATCH 1/3] Correct output from memreserve in fdtdump

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

On Wed, Jun 18, 2014 at 01:00:22AM -0600, Simon Glass wrote:
> This currently displays a hex value without the 0x prefix. Add the prefix
> as dtc requires it.
> 
> Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
>  fdtdump.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fdtdump.c b/fdtdump.c
> index 723770d..a29aa5e 100644
> --- a/fdtdump.c
> +++ b/fdtdump.c
> @@ -88,7 +88,7 @@ static void dump_blob(void *blob, bool debug)
>  		if (addr == 0 && size == 0)
>  			break;
>  
> -		printf("/memreserve/ %llx %llx;\n",
> +		printf("/memreserve/ %#llx %#llx;\n",

Is the # modifier and its behaviour standardized?  I couldn't quickly
find a reference.

Might be safer to do it as an explicit 0x%llx.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]