From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Devicetree Compiler
<devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
Subject: Re: [PATCH 1/3] Correct output from memreserve in fdtdump
Date: Wed, 18 Jun 2014 21:14:29 +1000 [thread overview]
Message-ID: <20140618111429.GG29264@voom.redhat.com> (raw)
In-Reply-To: <20140618103215.GF29264-1s0os16eZneny3qCrzbmXA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
On Wed, Jun 18, 2014 at 08:32:15PM +1000, David Gibson wrote:
> On Wed, Jun 18, 2014 at 01:00:22AM -0600, Simon Glass wrote:
> > This currently displays a hex value without the 0x prefix. Add the prefix
> > as dtc requires it.
> >
> > Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> > ---
> > fdtdump.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fdtdump.c b/fdtdump.c
> > index 723770d..a29aa5e 100644
> > --- a/fdtdump.c
> > +++ b/fdtdump.c
> > @@ -88,7 +88,7 @@ static void dump_blob(void *blob, bool debug)
> > if (addr == 0 && size == 0)
> > break;
> >
> > - printf("/memreserve/ %llx %llx;\n",
> > + printf("/memreserve/ %#llx %#llx;\n",
>
> Is the # modifier and its behaviour standardized? I couldn't quickly
> find a reference.
Never mind, found the reference, and the # flag's behaviour is there.
Applied.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-18 11:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 7:00 [PATCH 1/3] Correct output from memreserve in fdtdump Simon Glass
[not found] ` <1403074825-5069-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-06-18 7:00 ` [PATCH 2/3] Tweak code to display cell values Simon Glass
[not found] ` <1403074825-5069-2-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-06-18 11:15 ` David Gibson
2014-06-18 7:00 ` [PATCH 3/3] Add a basic test for fdtdump Simon Glass
[not found] ` <1403074825-5069-3-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-06-18 11:26 ` David Gibson
2014-06-18 10:32 ` [PATCH 1/3] Correct output from memreserve in fdtdump David Gibson
[not found] ` <20140618103215.GF29264-1s0os16eZneny3qCrzbmXA@public.gmane.org>
2014-06-18 11:14 ` David Gibson [this message]
[not found] ` <20140618111429.GG29264-1s0os16eZneny3qCrzbmXA@public.gmane.org>
2014-06-18 14:24 ` Jon Loeliger
[not found] ` <E1WxGmt-0004MW-Vk-CYoMK+44s/E@public.gmane.org>
2014-06-23 12:21 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618111429.GG29264@voom.redhat.com \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jdl-CYoMK+44s/E@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.