From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size
Date: Wed, 18 Jun 2014 15:31:45 +0100 [thread overview]
Message-ID: <20140618143145.GH2186@arm.com> (raw)
In-Reply-To: <1403099422-850-1-git-send-email-a.ryabinin@samsung.com>
On Wed, Jun 18, 2014 at 02:50:22PM +0100, Andrey Ryabinin wrote:
> Changing kernel stack size on arm is not as simple as it should be:
> 1) THRED_SIZE macro doen't respect PAGE_SIZE and THREAD_SIZE_ORDER
THREAD_SIZE
> 2) stack size is hardcoded in get_thread_info macro
>
> This patch fixes it by caculating THREAD_SIZE and thread_info address
> taking into account PAGE_SIZE and THREAD_SIZE_ORDER.
>
> Now changing stack size becomes simply changing THREAD_SIZE_ORDER.
Curious: is this just a cleanup, or are you actually running out of kernel
stack on an ARM platform?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Andrey Ryabinin <a.ryabinin@samsung.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Nicolas Pitre <nico@linaro.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size
Date: Wed, 18 Jun 2014 15:31:45 +0100 [thread overview]
Message-ID: <20140618143145.GH2186@arm.com> (raw)
In-Reply-To: <1403099422-850-1-git-send-email-a.ryabinin@samsung.com>
On Wed, Jun 18, 2014 at 02:50:22PM +0100, Andrey Ryabinin wrote:
> Changing kernel stack size on arm is not as simple as it should be:
> 1) THRED_SIZE macro doen't respect PAGE_SIZE and THREAD_SIZE_ORDER
THREAD_SIZE
> 2) stack size is hardcoded in get_thread_info macro
>
> This patch fixes it by caculating THREAD_SIZE and thread_info address
> taking into account PAGE_SIZE and THREAD_SIZE_ORDER.
>
> Now changing stack size becomes simply changing THREAD_SIZE_ORDER.
Curious: is this just a cleanup, or are you actually running out of kernel
stack on an ARM platform?
Will
next prev parent reply other threads:[~2014-06-18 14:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 13:50 [PATCH] arm: get rid of hardcoded assumptions about kernel stack size Andrey Ryabinin
2014-06-18 13:50 ` Andrey Ryabinin
2014-06-18 14:31 ` Will Deacon [this message]
2014-06-18 14:31 ` Will Deacon
2014-06-18 14:49 ` Andrey Ryabinin
2014-06-18 14:49 ` Andrey Ryabinin
2014-06-18 14:40 ` Nicolas Pitre
2014-06-18 14:40 ` Nicolas Pitre
2014-06-18 15:27 ` Andrey Ryabinin
2014-06-18 15:27 ` Andrey Ryabinin
2014-07-03 20:24 ` Arnd Bergmann
2014-07-03 20:24 ` Arnd Bergmann
2014-07-04 7:13 ` Andrey Ryabinin
2014-07-04 7:13 ` Andrey Ryabinin
2014-07-04 10:27 ` Arnd Bergmann
2014-07-04 10:27 ` Arnd Bergmann
2014-07-04 13:38 ` Andrey Ryabinin
2014-07-04 13:38 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618143145.GH2186@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.