From: Oleg Nesterov <oleg@redhat.com>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: akpm@linux-foundation.org, rientjes@google.com, cl@linux.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fork: dup_mm: init vm stat counters under mmap_sem
Date: Wed, 18 Jun 2014 17:22:09 +0200 [thread overview]
Message-ID: <20140618152209.GA14818@redhat.com> (raw)
In-Reply-To: <1403098391-24546-1-git-send-email-vdavydov@parallels.com>
On 06/18, Vladimir Davydov wrote:
>
> @@ -365,7 +365,12 @@ static int dup_mmap(struct mm_struct *mm, struct mm_struct *oldmm)
> */
> down_write_nested(&mm->mmap_sem, SINGLE_DEPTH_NESTING);
>
> + mm->total_vm = oldmm->total_vm;
> mm->locked_vm = 0;
> + mm->pinned_vm = 0;
> + mm->shared_vm = oldmm->shared_vm;
> + mm->exec_vm = oldmm->exec_vm;
> + mm->stack_vm = oldmm->stack_vm;
> mm->mmap = NULL;
> mm->vmacache_seqnum = 0;
> mm->map_count = 0;
I think the patch is fine.
But perhaps this deserves more cleanups, with or without this patch
the initialization does not look consistent. dup_mmap() nullifies
locked_vm/pinned_vm/mmap/map_count while mm_init() clears core_state/
nr_ptes/rss_stat.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: akpm@linux-foundation.org, rientjes@google.com, cl@linux.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fork: dup_mm: init vm stat counters under mmap_sem
Date: Wed, 18 Jun 2014 17:22:09 +0200 [thread overview]
Message-ID: <20140618152209.GA14818@redhat.com> (raw)
In-Reply-To: <1403098391-24546-1-git-send-email-vdavydov@parallels.com>
On 06/18, Vladimir Davydov wrote:
>
> @@ -365,7 +365,12 @@ static int dup_mmap(struct mm_struct *mm, struct mm_struct *oldmm)
> */
> down_write_nested(&mm->mmap_sem, SINGLE_DEPTH_NESTING);
>
> + mm->total_vm = oldmm->total_vm;
> mm->locked_vm = 0;
> + mm->pinned_vm = 0;
> + mm->shared_vm = oldmm->shared_vm;
> + mm->exec_vm = oldmm->exec_vm;
> + mm->stack_vm = oldmm->stack_vm;
> mm->mmap = NULL;
> mm->vmacache_seqnum = 0;
> mm->map_count = 0;
I think the patch is fine.
But perhaps this deserves more cleanups, with or without this patch
the initialization does not look consistent. dup_mmap() nullifies
locked_vm/pinned_vm/mmap/map_count while mm_init() clears core_state/
nr_ptes/rss_stat.
Oleg.
next prev parent reply other threads:[~2014-06-18 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 13:33 [PATCH] fork: dup_mm: init vm stat counters under mmap_sem Vladimir Davydov
2014-06-18 13:33 ` Vladimir Davydov
2014-06-18 15:22 ` Oleg Nesterov [this message]
2014-06-18 15:22 ` Oleg Nesterov
2014-06-19 7:14 ` Vladimir Davydov
2014-06-19 7:14 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618152209.GA14818@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.