Re: [PATCH v3 0/3] Qualcomm Resource Power Manager driver

[Lee Jones <lee.jones@linaro.org>]

On Wed, 18 Jun 2014, Kumar Gala wrote:

> 
> On Jun 18, 2014, at 10:53 AM, Kevin Hilman <khilman@linaro.org> wrote:
> 
> > Bjorn Andersson <bjorn@kryo.se> writes:
> > 
> >> On Tue, Jun 17, 2014 at 10:07 AM, Kevin Hilman <khilman@linaro.org> wrote:
> >>> +Paul Walmsley
> >>> 
> >>> Bjorn Andersson <bjorn.andersson@sonymobile.com> writes:
> >>> 
> >>>> This series adds a regulator driver for the Resource Power Manager found in
> >>>> Qualcomm 8660, 8960 and 8064 based devices.
> >>>> 
> >>>> The RPM driver exposes resources to its child devices, that can be accessed to
> >>>> implement drivers for the regulators, clocks and bus frequency control that's
> >>>> owned by the RPM in these devices.
> >>>> 
> >>>> Changes since v2:
> >>>>  - Fix copy-paste error in dt binding
> >>>>  - Correct incomplete move from mfd to soc
> >>>>  - Correct const mistake in regulator driver
> >>>> 
> >>>> Changes since v1:
> >>>>  - Moved rpm driver to drivers/soc
> >>> 
> >>> I'm not sure I follow the motivation for having this under drivers/soc?
> >>> 
> >> Hi Kevin,
> >> 
> >> I've made the argument that to me this is conceptually a black box
> >> handling regulators, clocks and other stuff; hence similar to a PMIC,
> >> which would fit nicely into drivers/mfd.
> >> 
> >> I still think this is the case and now that I look back I didn't get
> >> any pushback from Lee Jones so maybe the move was premature?
> > 
> > Yes, IMO, the move was premature, but hopefully the drivers/soc folks
> > can chime in an clarify the criteria for inclusion there.
> > 
> > Kevin
> 
> I dont agree, I think having this in drivers/soc means that we can
> clearly go through drivers/soc in the future and look for patterns
> across SoCs that should be re-factored.

> Where MFD seems like its become the new drivers misc.

Do you have any grounds for that statement?  I only know of one driver
which doesn't fit the bounds of a true MFD.  If you know of more, I'd
like to hear about it.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog