[PATCH] clkdev: Don't print errors on probe defer

[PATCH] clkdev: Don't print errors on probe defer

[Stephen Boyd]

This error message can spam the logs if you have lots of probe
deferals due to missing clocks. Just silence the error in this
case because the driver should try again later.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/clk/clkdev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index f890b901c6bc..da4bda8b7fc7 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -101,8 +101,9 @@ struct clk *of_clk_get_by_name(struct device_node *np, const char *name)
 		if (!IS_ERR(clk))
 			break;
 		else if (name && index >= 0) {
-			pr_err("ERROR: could not get clock %s:%s(%i)\n",
-				np->full_name, name ? name : "", index);
+			if (PTR_ERR(clk) != -EPROBE_DEFER)
+				pr_err("ERROR: could not get clock %s:%s(%i)\n",
+					np->full_name, name ? name : "", index);
 			return clk;
 		}
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

[PATCH] clkdev: Don't print errors on probe defer

[Stephen Boyd]

This error message can spam the logs if you have lots of probe
deferals due to missing clocks. Just silence the error in this
case because the driver should try again later.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/clk/clkdev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index f890b901c6bc..da4bda8b7fc7 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -101,8 +101,9 @@ struct clk *of_clk_get_by_name(struct device_node *np, const char *name)
 		if (!IS_ERR(clk))
 			break;
 		else if (name && index >= 0) {
-			pr_err("ERROR: could not get clock %s:%s(%i)\n",
-				np->full_name, name ? name : "", index);
+			if (PTR_ERR(clk) != -EPROBE_DEFER)
+				pr_err("ERROR: could not get clock %s:%s(%i)\n",
+					np->full_name, name ? name : "", index);
 			return clk;
 		}
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

[PATCH] clkdev: Don't print errors on probe defer

[Mike Turquette]

Quoting Stephen Boyd (2014-06-13 16:36:31)
> This error message can spam the logs if you have lots of probe
> deferals due to missing clocks. Just silence the error in this
> case because the driver should try again later.
> 
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Looks OK to me. Russell?

Regards,
Mike

> ---
>  drivers/clk/clkdev.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index f890b901c6bc..da4bda8b7fc7 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -101,8 +101,9 @@ struct clk *of_clk_get_by_name(struct device_node *np, const char *name)
>                 if (!IS_ERR(clk))
>                         break;
>                 else if (name && index >= 0) {
> -                       pr_err("ERROR: could not get clock %s:%s(%i)\n",
> -                               np->full_name, name ? name : "", index);
> +                       if (PTR_ERR(clk) != -EPROBE_DEFER)
> +                               pr_err("ERROR: could not get clock %s:%s(%i)\n",
> +                                       np->full_name, name ? name : "", index);
>                         return clk;
>                 }
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
> 

Re: [PATCH] clkdev: Don't print errors on probe defer

[Mike Turquette]

Quoting Stephen Boyd (2014-06-13 16:36:31)
> This error message can spam the logs if you have lots of probe
> deferals due to missing clocks. Just silence the error in this
> case because the driver should try again later.
> 
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Looks OK to me. Russell?

Regards,
Mike

> ---
>  drivers/clk/clkdev.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index f890b901c6bc..da4bda8b7fc7 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -101,8 +101,9 @@ struct clk *of_clk_get_by_name(struct device_node *np, const char *name)
>                 if (!IS_ERR(clk))
>                         break;
>                 else if (name && index >= 0) {
> -                       pr_err("ERROR: could not get clock %s:%s(%i)\n",
> -                               np->full_name, name ? name : "", index);
> +                       if (PTR_ERR(clk) != -EPROBE_DEFER)
> +                               pr_err("ERROR: could not get clock %s:%s(%i)\n",
> +                                       np->full_name, name ? name : "", index);
>                         return clk;
>                 }
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
> 

[PATCH] clkdev: Don't print errors on probe defer

[Russell King - ARM Linux]

On Tue, Jun 17, 2014 at 03:33:05PM -0700, Mike Turquette wrote:
> Quoting Stephen Boyd (2014-06-13 16:36:31)
> > This error message can spam the logs if you have lots of probe
> > deferals due to missing clocks. Just silence the error in this
> > case because the driver should try again later.
> > 
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> 
> Looks OK to me. Russell?

Looks fine to me too.  Should I assume you're looking to take it?

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

Re: [PATCH] clkdev: Don't print errors on probe defer

[Russell King - ARM Linux]

On Tue, Jun 17, 2014 at 03:33:05PM -0700, Mike Turquette wrote:
> Quoting Stephen Boyd (2014-06-13 16:36:31)
> > This error message can spam the logs if you have lots of probe
> > deferals due to missing clocks. Just silence the error in this
> > case because the driver should try again later.
> > 
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> 
> Looks OK to me. Russell?

Looks fine to me too.  Should I assume you're looking to take it?

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

[PATCH] clkdev: Don't print errors on probe defer

[Mike Turquette]

Quoting Russell King - ARM Linux (2014-06-17 15:48:06)
> On Tue, Jun 17, 2014 at 03:33:05PM -0700, Mike Turquette wrote:
> > Quoting Stephen Boyd (2014-06-13 16:36:31)
> > > This error message can spam the logs if you have lots of probe
> > > deferals due to missing clocks. Just silence the error in this
> > > case because the driver should try again later.
> > > 
> > > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > 
> > Looks OK to me. Russell?
> 
> Looks fine to me too.  Should I assume you're looking to take it?

Yes, I'll take it.

> 
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

Thanks for the Ack.

Regards,
Mike

> 
> -- 
> FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
> improving, and getting towards what was expected from it.