All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] toolchain-*.inc: Replace variable overrides with bb.utils function
@ 2014-06-18 15:01 Franklin S. Cooper Jr
  2014-06-19 16:18 ` Denys Dmytriyenko
  0 siblings, 1 reply; 7+ messages in thread
From: Franklin S. Cooper Jr @ 2014-06-18 15:01 UTC (permalink / raw)
  To: meta-arago; +Cc: Franklin S. Cooper Jr

* Conf files are unable to use variable overrides instead bitbake utility
  functions are needed to mimic the functionality.
* Currently the DEFAULTTUNE variable isn't being set properly for non Cortex A8
  devices which causes uses when using an architecture override for non Cortex
  A8 devices.
* This issue was first discovered due to the inability to build valgrind for
  am43x and via testing determined that this affected any non Cortex A8 machine/SOC_FAMILY
  within meta-ti.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
Version 2 changes:
Remove all the extra spaces

 .../conf/distro/include/toolchain-gcc.inc          |    7 ++++---
 .../conf/distro/include/toolchain-linaro.inc       |    9 +++++----
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/meta-arago-distro/conf/distro/include/toolchain-gcc.inc b/meta-arago-distro/conf/distro/include/toolchain-gcc.inc
index f7c8032..8388d13 100644
--- a/meta-arago-distro/conf/distro/include/toolchain-gcc.inc
+++ b/meta-arago-distro/conf/distro/include/toolchain-gcc.inc
@@ -3,9 +3,10 @@ TCMODE = "default"
 TCLIBC = "eglibc"
 
 DEFAULTTUNE = "cortexa8thf-neon"
-DEFAULTTUNE_omap-a15 = "cortexa15thf-neon"
-DEFAULTTUNE_keystone = "cortexa15thf-neon"
-DEFAULTTUNE_omap4 = "cortexa9thf-neon"
+DEFAULTTUNE := "${@bb.utils.contains('SOC_FAMILY','ti43x','cortexa9thf-neon','${DEFAULTTUNE}',d)}"
+DEFAULTTUNE := "${@bb.utils.contains('SOC_FAMILY','omap-a15','cortexa15thf-neon','${DEFAULTTUNE}',d)}"
+DEFAULTTUNE := "${@bb.utils.contains('SOC_FAMILY','keystone','cortexa15thf-neon','${DEFAULTTUNE}',d)}"
+DEFAULTTUNE := "${@bb.utils.contains('SOC_FAMILY','omap4','cortexa9thf-neon','${DEFAULTTUNE}',d)}"
 
 # Match some of the external vars
 TOOLCHAIN_SYS := "${TARGET_SYS}"
diff --git a/meta-arago-distro/conf/distro/include/toolchain-linaro.inc b/meta-arago-distro/conf/distro/include/toolchain-linaro.inc
index 95269a7..0418359 100644
--- a/meta-arago-distro/conf/distro/include/toolchain-linaro.inc
+++ b/meta-arago-distro/conf/distro/include/toolchain-linaro.inc
@@ -3,11 +3,12 @@ TCMODE = "external-linaro"
 TCLIBC = "external-linaro-toolchain"
 
 ELT_TARGET_SYS = "arm-linux-gnueabihf"
+
 DEFAULTTUNE = "cortexa8thf-neon"
-DEFAULTTUNE_omap-a15 = "cortexa15thf-neon"
-DEFAULTTUNE_keystone = "cortexa15thf-neon"
-DEFAULTTUNE_omap4 = "cortexa9thf-neon"
-DEFAULTTUNE_ti43x = "cortexa9thf-neon"
+DEFAULTTUNE := "${@bb.utils.contains('SOC_FAMILY','ti43x','cortexa9thf-neon','${DEFAULTTUNE}',d)}"
+DEFAULTTUNE := "${@bb.utils.contains('SOC_FAMILY','omap-a15','cortexa15thf-neon','${DEFAULTTUNE}',d)}"
+DEFAULTTUNE := "${@bb.utils.contains('SOC_FAMILY','keystone','cortexa15thf-neon','${DEFAULTTUNE}',d)}"
+DEFAULTTUNE := "${@bb.utils.contains('SOC_FAMILY','omap4','cortexa9thf-neon','${DEFAULTTUNE}',d)}"
 
 PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}gcc-intermediate = "external-linaro-toolchain"
 
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-06-19 20:32 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-18 15:01 [PATCH v2] toolchain-*.inc: Replace variable overrides with bb.utils function Franklin S. Cooper Jr
2014-06-19 16:18 ` Denys Dmytriyenko
2014-06-19 16:37   ` Cooper Jr., Franklin
2014-06-19 16:52     ` Denys Dmytriyenko
2014-06-19 18:01       ` Cooper Jr., Franklin
2014-06-19 19:16         ` Denys Dmytriyenko
2014-06-19 20:32           ` Cooper Jr., Franklin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.