From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM64: implement TASK_SIZE_OF
Date: Fri, 20 Jun 2014 09:25:20 +0100 [thread overview]
Message-ID: <20140620082520.GC25104@arm.com> (raw)
In-Reply-To: <1403122209-26352-1-git-send-email-ccross@android.com>
Hi Colin,
On Wed, Jun 18, 2014 at 09:10:09PM +0100, Colin Cross wrote:
> include/linux/sched.h implements TASK_SIZE_OF as TASK_SIZE if it
> is not set by the architecture headers. TASK_SIZE uses the
> current task to determine the size of the virtual address space.
> On a 64-bit kernel this will cause reading /proc/pid/pagemap of a
> 64-bit process from a 32-bit process to return EOF when it reads
> past 0xffffffff.
>
> Implement TASK_SIZE_OF exactly the same as TASK_SIZE with
> test_tsk_thread_flag instead of test_thread_flag.
Looks sane to me.
Acked-by: Will Deacon <will.deacon@arm.com>
I take it you're being bitten by this in real software, hence the CC stable
tag?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Colin Cross <ccross@android.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] ARM64: implement TASK_SIZE_OF
Date: Fri, 20 Jun 2014 09:25:20 +0100 [thread overview]
Message-ID: <20140620082520.GC25104@arm.com> (raw)
In-Reply-To: <1403122209-26352-1-git-send-email-ccross@android.com>
Hi Colin,
On Wed, Jun 18, 2014 at 09:10:09PM +0100, Colin Cross wrote:
> include/linux/sched.h implements TASK_SIZE_OF as TASK_SIZE if it
> is not set by the architecture headers. TASK_SIZE uses the
> current task to determine the size of the virtual address space.
> On a 64-bit kernel this will cause reading /proc/pid/pagemap of a
> 64-bit process from a 32-bit process to return EOF when it reads
> past 0xffffffff.
>
> Implement TASK_SIZE_OF exactly the same as TASK_SIZE with
> test_tsk_thread_flag instead of test_thread_flag.
Looks sane to me.
Acked-by: Will Deacon <will.deacon@arm.com>
I take it you're being bitten by this in real software, hence the CC stable
tag?
Will
next prev parent reply other threads:[~2014-06-20 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 20:10 [PATCH] ARM64: implement TASK_SIZE_OF Colin Cross
2014-06-18 20:10 ` Colin Cross
2014-06-20 8:25 ` Will Deacon [this message]
2014-06-20 8:25 ` Will Deacon
2014-06-20 21:24 ` Colin Cross
2014-06-20 21:24 ` Colin Cross
2014-06-23 11:13 ` Catalin Marinas
2014-06-23 11:13 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620082520.GC25104@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.