From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clocksource: arm_arch_timer: remove static from arch_timer_init
Date: Fri, 20 Jun 2014 11:52:17 +0100 [thread overview]
Message-ID: <20140620105217.GI30188@leverpostej> (raw)
In-Reply-To: <3602534.r5eJA8RqrN@diego>
On Fri, Jun 20, 2014 at 11:44:11AM +0100, Heiko St?bner wrote:
> There exist SoCs that need some special setup procedure for their architected-timer
> to work. Therefore allow arch_timer_init to be called from such specialized
> clocksources.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/clocksource/arm_arch_timer.c | 2 +-
> drivers/clocksource/arm_arch_timer.h | 7 +++++++
> 2 files changed, 8 insertions(+), 1 deletion(-)
> create mode 100644 drivers/clocksource/arm_arch_timer.h
>
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index 5163ec1..55116d6 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -635,7 +635,7 @@ static void __init arch_timer_common_init(void)
> arch_timer_arch_init();
> }
>
> -static void __init arch_timer_init(struct device_node *np)
> +void __init arch_timer_init(struct device_node *np)
> {
> int i;
>
> diff --git a/drivers/clocksource/arm_arch_timer.h b/drivers/clocksource/arm_arch_timer.h
> new file mode 100644
> index 0000000..af3974d
> --- /dev/null
> +++ b/drivers/clocksource/arm_arch_timer.h
> @@ -0,0 +1,7 @@
> +/*
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +void __init arch_timer_init(struct device_node *np);
If we _really_ need this (which I hope we don't), we already have
include/clocksource/arm_arch_timer.h.
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH 1/2] clocksource: arm_arch_timer: remove static from arch_timer_init
Date: Fri, 20 Jun 2014 11:52:17 +0100 [thread overview]
Message-ID: <20140620105217.GI30188@leverpostej> (raw)
In-Reply-To: <3602534.r5eJA8RqrN@diego>
On Fri, Jun 20, 2014 at 11:44:11AM +0100, Heiko Stübner wrote:
> There exist SoCs that need some special setup procedure for their architected-timer
> to work. Therefore allow arch_timer_init to be called from such specialized
> clocksources.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/clocksource/arm_arch_timer.c | 2 +-
> drivers/clocksource/arm_arch_timer.h | 7 +++++++
> 2 files changed, 8 insertions(+), 1 deletion(-)
> create mode 100644 drivers/clocksource/arm_arch_timer.h
>
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index 5163ec1..55116d6 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -635,7 +635,7 @@ static void __init arch_timer_common_init(void)
> arch_timer_arch_init();
> }
>
> -static void __init arch_timer_init(struct device_node *np)
> +void __init arch_timer_init(struct device_node *np)
> {
> int i;
>
> diff --git a/drivers/clocksource/arm_arch_timer.h b/drivers/clocksource/arm_arch_timer.h
> new file mode 100644
> index 0000000..af3974d
> --- /dev/null
> +++ b/drivers/clocksource/arm_arch_timer.h
> @@ -0,0 +1,7 @@
> +/*
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +void __init arch_timer_init(struct device_node *np);
If we _really_ need this (which I hope we don't), we already have
include/clocksource/arm_arch_timer.h.
Mark.
next prev parent reply other threads:[~2014-06-20 10:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 10:43 [PATCH 0/2] clocksource: add rockchip rk3288 specific armv7-timer Heiko Stübner
2014-06-20 10:43 ` Heiko Stübner
2014-06-20 10:43 ` Heiko Stübner
2014-06-20 10:44 ` [PATCH 1/2] clocksource: arm_arch_timer: remove static from arch_timer_init Heiko Stübner
2014-06-20 10:44 ` Heiko Stübner
2014-06-20 10:44 ` Heiko Stübner
2014-06-20 10:52 ` Mark Rutland [this message]
2014-06-20 10:52 ` Mark Rutland
2014-06-20 10:44 ` [PATCH 2/2] clocksource: add rockchip-specific armv7-timer setup Heiko Stübner
2014-06-20 10:44 ` Heiko Stübner
2014-06-20 10:51 ` Mark Rutland
2014-06-20 10:51 ` Mark Rutland
2014-06-20 11:27 ` Heiko Stübner
2014-06-20 11:27 ` Heiko Stübner
2014-06-20 11:27 ` Heiko Stübner
2014-06-20 12:14 ` Mark Rutland
2014-06-20 12:14 ` Mark Rutland
2014-06-20 12:14 ` Mark Rutland
2014-06-23 10:54 ` Matthias Brugger
2014-06-23 10:54 ` Matthias Brugger
2014-06-23 10:54 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620105217.GI30188@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.