From: Matt Porter <mporter@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Chris Ball <chris@printf.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Christian Daudt <csd@broadcom.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Sachin Kamat <sachin.kamat@linaro.org>,
Markus Mayer <markus.mayer@linaro.org>,
Tim Kryger <tim.kryger@linaro.org>,
Axel Lin <axel.lin@ingics.com>,
linux-mmc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mmc: sdhci-bcm-kona: | vs & typo in debug code
Date: Fri, 20 Jun 2014 11:41:31 +0000 [thread overview]
Message-ID: <20140620114131.GA18931@beef> (raw)
In-Reply-To: <20140620071901.GA22779@mwanda>
On Fri, Jun 20, 2014 at 10:19:01AM +0300, Dan Carpenter wrote:
> The debug printk says that 8bit is always true because of a '|' vs '&'
> typo.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Matt Porter <mporter@linaro.org>
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index dd780c3..2d3f3c0 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -290,7 +290,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>
> dev_dbg(dev, "is_8bit=%c\n",
> - (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
> + (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
>
> ret = sdhci_bcm_kona_sd_reset(host);
> if (ret)
WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <mporter@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Chris Ball <chris@printf.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Christian Daudt <csd@broadcom.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Sachin Kamat <sachin.kamat@linaro.org>,
Markus Mayer <markus.mayer@linaro.org>,
Tim Kryger <tim.kryger@linaro.org>,
Axel Lin <axel.lin@ingics.com>,
linux-mmc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mmc: sdhci-bcm-kona: | vs & typo in debug code
Date: Fri, 20 Jun 2014 07:41:31 -0400 [thread overview]
Message-ID: <20140620114131.GA18931@beef> (raw)
In-Reply-To: <20140620071901.GA22779@mwanda>
On Fri, Jun 20, 2014 at 10:19:01AM +0300, Dan Carpenter wrote:
> The debug printk says that 8bit is always true because of a '|' vs '&'
> typo.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Matt Porter <mporter@linaro.org>
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index dd780c3..2d3f3c0 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -290,7 +290,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>
> dev_dbg(dev, "is_8bit=%c\n",
> - (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
> + (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
>
> ret = sdhci_bcm_kona_sd_reset(host);
> if (ret)
next prev parent reply other threads:[~2014-06-20 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 7:19 [patch] mmc: sdhci-bcm-kona: | vs & typo in debug code Dan Carpenter
2014-06-20 7:19 ` Dan Carpenter
2014-06-20 11:41 ` Matt Porter [this message]
2014-06-20 11:41 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620114131.GA18931@beef \
--to=mporter@linaro.org \
--cc=axel.lin@ingics.com \
--cc=chris@printf.net \
--cc=csd@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=grant.likely@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=tim.kryger@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.