From: Minchan Kim <minchan@kernel.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 4/4] mm: vmscan: move swappiness out of scan_control
Date: Mon, 23 Jun 2014 15:51:41 +0900 [thread overview]
Message-ID: <20140623065141.GD15594@bbox> (raw)
In-Reply-To: <1403282030-29915-4-git-send-email-hannes@cmpxchg.org>
On Fri, Jun 20, 2014 at 12:33:50PM -0400, Johannes Weiner wrote:
> Swappiness is determined for each scanned memcg individually in
> shrink_zone() and is not a parameter that applies throughout the
> reclaim scan. Move it out of struct scan_control to prevent
> accidental use of a stale value.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 4/4] mm: vmscan: move swappiness out of scan_control
Date: Mon, 23 Jun 2014 15:51:41 +0900 [thread overview]
Message-ID: <20140623065141.GD15594@bbox> (raw)
In-Reply-To: <1403282030-29915-4-git-send-email-hannes@cmpxchg.org>
On Fri, Jun 20, 2014 at 12:33:50PM -0400, Johannes Weiner wrote:
> Swappiness is determined for each scanned memcg individually in
> shrink_zone() and is not a parameter that applies throughout the
> reclaim scan. Move it out of struct scan_control to prevent
> accidental use of a stale value.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2014-06-23 6:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 16:33 [patch 1/4] mm: vmscan: remove remains of kswapd-managed zone->all_unreclaimable Johannes Weiner
2014-06-20 16:33 ` Johannes Weiner
2014-06-20 16:33 ` [patch 2/4] mm: vmscan: rework compaction-ready signaling in direct reclaim Johannes Weiner
2014-06-20 16:33 ` Johannes Weiner
2014-06-20 16:56 ` Vlastimil Babka
2014-06-20 16:56 ` Vlastimil Babka
2014-06-20 20:24 ` Johannes Weiner
2014-06-20 20:24 ` Johannes Weiner
2014-06-23 7:28 ` Michal Hocko
2014-06-23 7:28 ` Michal Hocko
2014-06-23 6:36 ` Minchan Kim
2014-06-23 6:36 ` Minchan Kim
2014-06-23 18:20 ` Johannes Weiner
2014-06-23 18:20 ` Johannes Weiner
2014-06-23 13:07 ` Mel Gorman
2014-06-23 13:07 ` Mel Gorman
2014-06-23 17:20 ` Johannes Weiner
2014-06-23 17:20 ` Johannes Weiner
2014-06-25 9:55 ` Mel Gorman
2014-06-25 9:55 ` Mel Gorman
2014-06-20 16:33 ` [patch 3/4] mm: vmscan: remove all_unreclaimable() Johannes Weiner
2014-06-20 16:33 ` Johannes Weiner
2014-06-23 6:48 ` Minchan Kim
2014-06-23 6:48 ` Minchan Kim
2014-06-23 8:35 ` Michal Hocko
2014-06-23 8:35 ` Michal Hocko
2014-06-23 13:32 ` Mel Gorman
2014-06-23 13:32 ` Mel Gorman
2014-06-20 16:33 ` [patch 4/4] mm: vmscan: move swappiness out of scan_control Johannes Weiner
2014-06-20 16:33 ` Johannes Weiner
2014-06-23 6:51 ` Minchan Kim [this message]
2014-06-23 6:51 ` Minchan Kim
2014-06-23 9:12 ` Michal Hocko
2014-06-23 9:12 ` Michal Hocko
2014-06-23 6:16 ` [patch 1/4] mm: vmscan: remove remains of kswapd-managed zone->all_unreclaimable Minchan Kim
2014-06-23 6:16 ` Minchan Kim
2014-06-23 16:01 ` Motohiro Kosaki
2014-06-23 16:01 ` Motohiro Kosaki
2014-06-23 7:49 ` Michal Hocko
2014-06-23 7:49 ` Michal Hocko
2014-06-23 12:56 ` Mel Gorman
2014-06-23 12:56 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623065141.GD15594@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.