From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-trivial@nongnu.org, BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] pc: Fix "prog_if" typo on PC_COMPAT_2_0
Date: Wed, 25 Jun 2014 09:00:59 +0300 [thread overview]
Message-ID: <20140625060059.GC21553@redhat.com> (raw)
In-Reply-To: <1403650675-3368-1-git-send-email-ehabkost@redhat.com>
On Tue, Jun 24, 2014 at 07:57:55PM -0300, Eduardo Habkost wrote:
> The property name is "prog_if", not "prof_if".
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Cc: BALATON Zoltan <balaton@eik.bme.hu>
Should be reported-by, by the way.
Cc: means "I have notified this person just in case".
> ---
> include/hw/i386/pc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 486e98f..1331d5a 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> },\
> {\
> .driver = "pci-serial-2x",\
> - .property = "prof_if",\
> + .property = "prog_if",\
> .value = stringify(0),\
> },\
> {\
> --
> 1.9.3
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pc: Fix "prog_if" typo on PC_COMPAT_2_0
Date: Wed, 25 Jun 2014 09:00:59 +0300 [thread overview]
Message-ID: <20140625060059.GC21553@redhat.com> (raw)
In-Reply-To: <1403650675-3368-1-git-send-email-ehabkost@redhat.com>
On Tue, Jun 24, 2014 at 07:57:55PM -0300, Eduardo Habkost wrote:
> The property name is "prog_if", not "prof_if".
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Cc: BALATON Zoltan <balaton@eik.bme.hu>
Should be reported-by, by the way.
Cc: means "I have notified this person just in case".
> ---
> include/hw/i386/pc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 486e98f..1331d5a 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> },\
> {\
> .driver = "pci-serial-2x",\
> - .property = "prof_if",\
> + .property = "prog_if",\
> .value = stringify(0),\
> },\
> {\
> --
> 1.9.3
next prev parent reply other threads:[~2014-06-25 6:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 22:57 [Qemu-trivial] [PATCH] pc: Fix "prog_if" typo on PC_COMPAT_2_0 Eduardo Habkost
2014-06-24 22:57 ` [Qemu-devel] " Eduardo Habkost
2014-06-25 5:58 ` [Qemu-trivial] " Michael S. Tsirkin
2014-06-25 5:58 ` [Qemu-devel] " Michael S. Tsirkin
2014-06-25 6:00 ` Michael S. Tsirkin [this message]
2014-06-25 6:00 ` Michael S. Tsirkin
2014-06-25 6:01 ` [Qemu-trivial] " Michael S. Tsirkin
2014-06-25 6:01 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625060059.GC21553@redhat.com \
--to=mst@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.