From: Lee Jones <lee.jones@linaro.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <acourbot@nvidia.com>,
Jingoo Han <jg1.han@samsung.com>, Bryan Wu <cooloney@gmail.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
gnurou@gmail.com
Subject: Re: [PATCH] pwm-backlight: use devm_gpiod_get_optional()
Date: Wed, 25 Jun 2014 12:03:31 +0000 [thread overview]
Message-ID: <20140625120331.GE13518@lee--X1> (raw)
In-Reply-To: <20140625111346.GB21208@ulmo>
On Wed, 25 Jun 2014, Thierry Reding wrote:
> On Wed, Jun 25, 2014 at 10:54:47AM +0100, Lee Jones wrote:
> > > Make use of the new devm_gpiod_get_optional() to simplify the probe
> > > code.
> > >
> > > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> > > ---
> > > drivers/video/backlight/pwm_bl.c | 7 ++-----
> > > 1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > Looks good. Applied, thanks.
>
> Technically pwm_bl.c is my turf. However I only adopted it way back when
> the backlight subsystem was orphaned, but it seems Jingoo, Bryan and you
> are taking good care of it these days, so perhaps it would be a good
> idea to move it back to your custody?
Yeah, the whole 'driver maintainer' sketch could get pretty complex.
It's pretty clean-cut in the PWM subsystem as only one exists, but
Backlight and MFD have a whole bunch, and I don't usually wait for
them to Ack/Nack before applying or providing review comments.
I'm happy to play it however you like really. I'm sure the boys and I
can handle it if you so wish. Even better if you would say in the
MAINTAINERS file and provide review comments when patches are
submitted. I do think all 'drivers/video/backlight' changes should go
in via the Backlight tree though.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <acourbot@nvidia.com>,
Jingoo Han <jg1.han@samsung.com>, Bryan Wu <cooloney@gmail.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
gnurou@gmail.com
Subject: Re: [PATCH] pwm-backlight: use devm_gpiod_get_optional()
Date: Wed, 25 Jun 2014 13:03:31 +0100 [thread overview]
Message-ID: <20140625120331.GE13518@lee--X1> (raw)
In-Reply-To: <20140625111346.GB21208@ulmo>
On Wed, 25 Jun 2014, Thierry Reding wrote:
> On Wed, Jun 25, 2014 at 10:54:47AM +0100, Lee Jones wrote:
> > > Make use of the new devm_gpiod_get_optional() to simplify the probe
> > > code.
> > >
> > > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> > > ---
> > > drivers/video/backlight/pwm_bl.c | 7 ++-----
> > > 1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > Looks good. Applied, thanks.
>
> Technically pwm_bl.c is my turf. However I only adopted it way back when
> the backlight subsystem was orphaned, but it seems Jingoo, Bryan and you
> are taking good care of it these days, so perhaps it would be a good
> idea to move it back to your custody?
Yeah, the whole 'driver maintainer' sketch could get pretty complex.
It's pretty clean-cut in the PWM subsystem as only one exists, but
Backlight and MFD have a whole bunch, and I don't usually wait for
them to Ack/Nack before applying or providing review comments.
I'm happy to play it however you like really. I'm sure the boys and I
can handle it if you so wish. Even better if you would say in the
MAINTAINERS file and provide review comments when patches are
submitted. I do think all 'drivers/video/backlight' changes should go
in via the Backlight tree though.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-06-25 12:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 9:18 [PATCH] pwm-backlight: use devm_gpiod_get_optional() Alexandre Courbot
2014-06-25 9:18 ` Alexandre Courbot
2014-06-25 9:54 ` Lee Jones
2014-06-25 9:54 ` Lee Jones
2014-06-25 11:13 ` Thierry Reding
2014-06-25 11:13 ` Thierry Reding
2014-06-25 12:03 ` Lee Jones [this message]
2014-06-25 12:03 ` Lee Jones
2014-06-27 6:13 ` Thierry Reding
2014-06-27 6:13 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625120331.GE13518@lee--X1 \
--to=lee.jones@linaro.org \
--cc=acourbot@nvidia.com \
--cc=cooloney@gmail.com \
--cc=gnurou@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.