From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Jason Kridner" <jkridner@gmail.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-omap <linux-omap@vger.kernel.org>,
"Robert Nelson" <robertcnelson@gmail.com>,
"Guido Martínez" <guido@vanguardiasur.com.ar>
Subject: Re: [PATCH v1 3/3] ARM: dts: am335x-bone: add support for beaglebone LCD4 cape
Date: Wed, 25 Jun 2014 11:59:10 -0300 [thread overview]
Message-ID: <20140625145910.GC743@arch.cereza> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EAF7327@DBDE04.ent.ti.com>
On 25 Jun 04:38 AM, Gupta, Pekon wrote:
> >From: Ezequiel Garcia
> >>On 24 Jun 05:54 PM, Pekon Gupta wrote:
> >> This patch adds support for LCD4 cape as advertised on
> >> http://elinux.org/CircuitCo:BeagleBone_LCD4
> >>
> >> This cape has:
> >> * 480x272 TFT-LCD panel
> >> - LCD panel datasheet and timing information are sourced from [1]
> >> - LCD backlight is connected to 'EHRPWM1A' on cape board, but its used for
> >> enabling backlight power-supply. So 'gpio-backlight' driver is used instead
> >> of 'pwm-backlight' driver (Kconfig: BACKLIGHT_GPIO=y).
> >>
> >
> >I'm confused about this, can you clarify why you are not using pwm-backlight?
> >
>
> As per the schematics of this LCD4 cape board, "EHRPWM1A" pin controls
> enabling/disabling of the power to backlight LED. It does not control the
> voltage levels (brightness levels) of the LED. Thus it wasn't making sense
> to use pwm-backlight driver which more suitable in cases where you have
> multiple levels of brightness.
> Here, you have only 2 levels "backlight=off | on", so I used gpio-backlight driver.
> Though you can use pwm-backlight driver also, but the backlight turns ON
> only when you set the /sys/class/backlight/<backlight_device>/brighteness
> to maximum level (as set in DT).
>
Hm, I didn't know that. Thanks for this information.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Jason Kridner" <jkridner@gmail.com>,
"Robert Nelson" <robertcnelson@gmail.com>,
linux-omap <linux-omap@vger.kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
"Guido Martínez" <guido@vanguardiasur.com.ar>
Subject: Re: [PATCH v1 3/3] ARM: dts: am335x-bone: add support for beaglebone LCD4 cape
Date: Wed, 25 Jun 2014 11:59:10 -0300 [thread overview]
Message-ID: <20140625145910.GC743@arch.cereza> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EAF7327@DBDE04.ent.ti.com>
On 25 Jun 04:38 AM, Gupta, Pekon wrote:
> >From: Ezequiel Garcia
> >>On 24 Jun 05:54 PM, Pekon Gupta wrote:
> >> This patch adds support for LCD4 cape as advertised on
> >> http://elinux.org/CircuitCo:BeagleBone_LCD4
> >>
> >> This cape has:
> >> * 480x272 TFT-LCD panel
> >> - LCD panel datasheet and timing information are sourced from [1]
> >> - LCD backlight is connected to 'EHRPWM1A' on cape board, but its used for
> >> enabling backlight power-supply. So 'gpio-backlight' driver is used instead
> >> of 'pwm-backlight' driver (Kconfig: BACKLIGHT_GPIO=y).
> >>
> >
> >I'm confused about this, can you clarify why you are not using pwm-backlight?
> >
>
> As per the schematics of this LCD4 cape board, "EHRPWM1A" pin controls
> enabling/disabling of the power to backlight LED. It does not control the
> voltage levels (brightness levels) of the LED. Thus it wasn't making sense
> to use pwm-backlight driver which more suitable in cases where you have
> multiple levels of brightness.
> Here, you have only 2 levels "backlight=off | on", so I used gpio-backlight driver.
> Though you can use pwm-backlight driver also, but the backlight turns ON
> only when you set the /sys/class/backlight/<backlight_device>/brighteness
> to maximum level (as set in DT).
>
Hm, I didn't know that. Thanks for this information.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2014-06-25 15:00 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 12:24 [PATCH v1 0/3] ARM: dts: am335x-bone: Beaglebone cape DTS Pekon Gupta
2014-06-24 12:24 ` Pekon Gupta
2014-06-24 12:24 ` [PATCH v1 1/3] ARM: dts: am335x-bone: add support for beaglebone NAND cape Pekon Gupta
2014-06-24 12:24 ` Pekon Gupta
2014-06-25 15:27 ` Ezequiel Garcia
2014-06-25 15:27 ` Ezequiel Garcia
2014-06-26 5:43 ` Gupta, Pekon
2014-06-26 5:43 ` Gupta, Pekon
2014-06-26 10:40 ` Tony Lindgren
2014-06-26 10:40 ` Tony Lindgren
2014-06-26 15:06 ` Guido Martínez
2014-06-26 15:06 ` Guido Martínez
2014-07-01 7:01 ` Gupta, Pekon
2014-07-01 7:01 ` Gupta, Pekon
2014-07-01 23:42 ` Guido Martínez
2014-07-01 23:42 ` Guido Martínez
2014-07-02 5:29 ` Gupta, Pekon
2014-07-02 5:29 ` Gupta, Pekon
2014-06-26 19:48 ` Guido Martínez
2014-06-26 19:48 ` Guido Martínez
2014-06-27 21:06 ` Gupta, Pekon
2014-06-27 21:06 ` Gupta, Pekon
2014-07-01 8:47 ` Tony Lindgren
2014-07-01 8:47 ` Tony Lindgren
2014-07-01 9:07 ` Gupta, Pekon
2014-07-01 9:07 ` Gupta, Pekon
2014-07-01 13:28 ` Tony Lindgren
2014-07-01 13:28 ` Tony Lindgren
2014-06-24 12:24 ` [PATCH v1 2/3] ARM: dts: am335x-bone: add support for beaglebone NOR cape Pekon Gupta
2014-06-24 12:24 ` Pekon Gupta
2014-06-24 12:24 ` [PATCH v1 3/3] ARM: dts: am335x-bone: add support for beaglebone LCD4 cape Pekon Gupta
2014-06-24 12:24 ` Pekon Gupta
2014-06-24 15:03 ` Ezequiel Garcia
2014-06-24 15:03 ` Ezequiel Garcia
2014-06-25 4:38 ` Gupta, Pekon
2014-06-25 4:38 ` Gupta, Pekon
2014-06-25 14:59 ` Ezequiel Garcia [this message]
2014-06-25 14:59 ` Ezequiel Garcia
2014-06-24 15:24 ` Jason Kridner
2014-06-24 15:24 ` Jason Kridner
2014-06-25 5:49 ` Gupta, Pekon
2014-06-25 5:49 ` Gupta, Pekon
2014-06-26 4:30 ` Jason Kridner
2014-06-26 4:30 ` Jason Kridner
2014-06-26 15:40 ` Guido Martínez
2014-06-26 15:40 ` Guido Martínez
2014-06-26 18:35 ` Darren Etheridge
2014-06-26 18:35 ` Darren Etheridge
2014-06-27 11:38 ` Gupta, Pekon
2014-06-27 11:38 ` Gupta, Pekon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625145910.GC743@arch.cereza \
--to=ezequiel@vanguardiasur.com.ar \
--cc=guido@vanguardiasur.com.ar \
--cc=jkridner@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=pekon@ti.com \
--cc=robertcnelson@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.