From: "maxime.ripard" <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Emilio Lopez <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Boris BREZILLON
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Luc Verhaegen <libv-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: Re: [PATCH v2 12/20] clk: sunxi: Add A23 APB0 support to sun6i-a31-apb0-clk
Date: Wed, 25 Jun 2014 18:41:07 +0200 [thread overview]
Message-ID: <20140625164107.GA19569@lukather> (raw)
In-Reply-To: <CAGb2v64hFc7oVdydoNzKVqjnyNUxuqMXX2AiV3aJLFizKvkOPA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On Fri, Jun 20, 2014 at 02:13:58PM +0800, Chen-Yu Tsai wrote:
> > If these two clocks are these different though, maybe it would just be
> > easier to add a new driver. These are trivial enough anyway.
>
> Yes it is. But it adds more of the same boilerplate code than actual
> differences of the hardware.
>
> I'm inclined to keep it as it is for now, unless someone strongly
> objects.
I'm not strongly objecting, but I'd strongly prefer to go with two
drivers.
I don't really want to end up in the same case than with clk-sunxi.c,
which handles a lot of weird corner case for one particular clock,
while most of them are just a single-bit gate.
Especially when they have nothing in common, which is pretty much the
case here.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (maxime.ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH v2 12/20] clk: sunxi: Add A23 APB0 support to sun6i-a31-apb0-clk
Date: Wed, 25 Jun 2014 18:41:07 +0200 [thread overview]
Message-ID: <20140625164107.GA19569@lukather> (raw)
In-Reply-To: <CAGb2v64hFc7oVdydoNzKVqjnyNUxuqMXX2AiV3aJLFizKvkOPA@mail.gmail.com>
On Fri, Jun 20, 2014 at 02:13:58PM +0800, Chen-Yu Tsai wrote:
> > If these two clocks are these different though, maybe it would just be
> > easier to add a new driver. These are trivial enough anyway.
>
> Yes it is. But it adds more of the same boilerplate code than actual
> differences of the hardware.
>
> I'm inclined to keep it as it is for now, unless someone strongly
> objects.
I'm not strongly objecting, but I'd strongly prefer to go with two
drivers.
I don't really want to end up in the same case than with clk-sunxi.c,
which handles a lot of weird corner case for one particular clock,
while most of them are just a single-bit gate.
Especially when they have nothing in common, which is pretty much the
case here.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140625/d7d93676/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: "maxime.ripard" <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mike Turquette <mturquette@linaro.org>,
Emilio Lopez <emilio@elopez.com.ar>,
Linus Walleij <linus.walleij@linaro.org>,
linux-serial@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Luc Verhaegen <libv@skynet.be>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] Re: [PATCH v2 12/20] clk: sunxi: Add A23 APB0 support to sun6i-a31-apb0-clk
Date: Wed, 25 Jun 2014 18:41:07 +0200 [thread overview]
Message-ID: <20140625164107.GA19569@lukather> (raw)
In-Reply-To: <CAGb2v64hFc7oVdydoNzKVqjnyNUxuqMXX2AiV3aJLFizKvkOPA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On Fri, Jun 20, 2014 at 02:13:58PM +0800, Chen-Yu Tsai wrote:
> > If these two clocks are these different though, maybe it would just be
> > easier to add a new driver. These are trivial enough anyway.
>
> Yes it is. But it adds more of the same boilerplate code than actual
> differences of the hardware.
>
> I'm inclined to keep it as it is for now, unless someone strongly
> objects.
I'm not strongly objecting, but I'd strongly prefer to go with two
drivers.
I don't really want to end up in the same case than with clk-sunxi.c,
which handles a lot of weird corner case for one particular clock,
while most of them are just a single-bit gate.
Especially when they have nothing in common, which is pretty much the
case here.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-25 16:41 UTC|newest]
Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 14:52 [PATCH v2 00/20] ARM: sunxi: Introduce Allwinner A23 (sun8i) support Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-1-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-17 14:52 ` [PATCH v2 01/20] serial: 8250_dw: Add optional reset control support Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-2-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-18 9:08 ` Maxime Ripard
2014-06-18 9:08 ` Maxime Ripard
2014-06-18 9:08 ` Maxime Ripard
2014-06-17 14:52 ` [PATCH v2 02/20] clk: sunxi: register clock gates with clkdev Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` [PATCH v2 03/20] clk: sunxi: move "ahb_sdram" to protected clock list Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-4-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-18 9:10 ` Maxime Ripard
2014-06-18 9:10 ` Maxime Ripard
2014-06-18 9:10 ` Maxime Ripard
2014-06-17 14:52 ` [PATCH v2 04/20] clk: sunxi: Fix gate indexing for sun6i-a31-apb0-gates Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-5-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-18 9:38 ` Maxime Ripard
2014-06-18 9:38 ` Maxime Ripard
2014-06-18 9:38 ` Maxime Ripard
2014-06-17 14:52 ` [PATCH v2 05/20] clk: sunxi: Support factor clocks with N multiplier factor starting from 1 Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-6-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-17 21:23 ` Rob Herring
2014-06-17 21:23 ` Rob Herring
2014-06-17 21:23 ` Rob Herring
2014-06-18 9:42 ` Maxime Ripard
2014-06-18 9:42 ` Maxime Ripard
2014-06-18 9:42 ` Maxime Ripard
2014-06-17 14:52 ` [PATCH v2 06/20] clk: sunxi: Fix rate_recalc for sun6i PLL1 Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` [PATCH v2 07/20] clk: sunxi: Fix PLL6 calculation on sun6i Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` [PATCH v2 08/20] ARM: sun6i: DT: Rename PLL6 to PLL6x2 and add fixed-factor-clock for PLL6 Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-9-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-18 9:57 ` Maxime Ripard
2014-06-18 9:57 ` Maxime Ripard
2014-06-18 9:57 ` Maxime Ripard
2014-06-17 14:52 ` [PATCH v2 09/20] clk: sunxi: Add sun6i MBUS clock support Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-10-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-18 10:04 ` Maxime Ripard
2014-06-18 10:04 ` Maxime Ripard
2014-06-18 10:04 ` Maxime Ripard
2014-06-23 4:44 ` Chen-Yu Tsai
2014-06-23 4:44 ` Chen-Yu Tsai
2014-06-23 4:44 ` Chen-Yu Tsai
2014-06-17 14:52 ` [PATCH v2 10/20] clk: sunxi: Add support for table-based divider clocks Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-11-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-18 10:06 ` Maxime Ripard
2014-06-18 10:06 ` Maxime Ripard
2014-06-18 10:06 ` Maxime Ripard
2014-06-17 14:52 ` [PATCH v2 11/20] clk: sunxi: Add A23 clocks support Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-12-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-18 10:16 ` Maxime Ripard
2014-06-18 10:16 ` Maxime Ripard
2014-06-18 10:16 ` Maxime Ripard
2014-06-19 4:07 ` Chen-Yu Tsai
2014-06-19 4:07 ` Chen-Yu Tsai
2014-06-19 4:07 ` Chen-Yu Tsai
2014-06-17 14:52 ` [PATCH v2 12/20] clk: sunxi: Add A23 APB0 support to sun6i-a31-apb0-clk Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-13-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-18 10:26 ` Maxime Ripard
2014-06-18 10:26 ` Maxime Ripard
2014-06-18 10:26 ` Maxime Ripard
2014-06-19 4:33 ` Chen-Yu Tsai
2014-06-19 4:33 ` Chen-Yu Tsai
2014-06-19 4:33 ` Chen-Yu Tsai
[not found] ` <CAGb2v64D6qBtXGXzn25443s_oj_=Z-u_P6+-MX52Lz54+9bQyQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-19 9:28 ` Maxime Ripard
2014-06-19 9:28 ` Maxime Ripard
2014-06-19 9:28 ` Maxime Ripard
2014-06-20 6:13 ` Chen-Yu Tsai
2014-06-20 6:13 ` [linux-sunxi] " Chen-Yu Tsai
2014-06-20 6:13 ` Chen-Yu Tsai
[not found] ` <CAGb2v64hFc7oVdydoNzKVqjnyNUxuqMXX2AiV3aJLFizKvkOPA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-25 16:41 ` maxime.ripard [this message]
2014-06-25 16:41 ` maxime.ripard
2014-06-25 16:41 ` maxime.ripard
2014-06-17 14:52 ` [PATCH v2 14/20] pinctrl: sunxi: Add A23 PIO controller support Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-15-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-07-07 13:00 ` Linus Walleij
2014-07-07 13:00 ` Linus Walleij
2014-07-07 13:00 ` Linus Walleij
2014-06-17 14:52 ` [PATCH v2 15/20] pinctrl: sunxi: Add A23 R_PIO " Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-16-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-07-07 13:17 ` Linus Walleij
2014-07-07 13:17 ` Linus Walleij
2014-07-07 13:17 ` Linus Walleij
2014-06-17 14:52 ` [PATCH v2 16/20] mfd: sun6i-prcm: Add support for Allwinner A23 PRCM Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-17-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-18 8:29 ` Lee Jones
2014-06-18 8:29 ` Lee Jones
2014-06-18 8:29 ` Lee Jones
2014-06-18 12:24 ` Maxime Ripard
2014-06-18 12:24 ` Maxime Ripard
2014-06-18 12:24 ` Maxime Ripard
2014-06-20 7:38 ` Chen-Yu Tsai
2014-06-20 7:38 ` Chen-Yu Tsai
2014-06-20 7:38 ` Chen-Yu Tsai
2014-06-17 14:52 ` [PATCH v2 17/20] ARM: sunxi: Introduce Allwinner A23 support Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-18-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-18 12:26 ` Maxime Ripard
2014-06-18 12:26 ` Maxime Ripard
2014-06-18 12:26 ` Maxime Ripard
2014-06-20 5:56 ` Chen-Yu Tsai
2014-06-20 5:56 ` [linux-sunxi] " Chen-Yu Tsai
2014-06-20 5:56 ` Chen-Yu Tsai
[not found] ` <CAGb2v67zkwvspdDr-rKv=5uT5mvP4e1ZyzHSSOXmvaiOxA+7OA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-20 5:59 ` Fwd: " Chen-Yu Tsai
2014-06-20 5:59 ` Fwd: [linux-sunxi] " Chen-Yu Tsai
2014-06-20 5:59 ` Chen-Yu Tsai
2014-06-17 14:52 ` [PATCH v2 18/20] ARM: sunxi: Add earlyprintk support using R_UART (sun6i/sun8i) Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-19-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-18 12:29 ` Maxime Ripard
2014-06-18 12:29 ` Maxime Ripard
2014-06-18 12:29 ` Maxime Ripard
2014-06-17 14:52 ` [PATCH v2 19/20] ARM: sunxi: Add Allwinner A23 dtsi Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` [PATCH v2 20/20] ARM: sun8i: dt: Add Ippo-q8h v5 support Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
2014-06-17 14:52 ` [PATCH v2 13/20] clk: sunxi: Add A23 specific compatible to sun6i-a31-apb0-gates-clk Chen-Yu Tsai
2014-06-17 14:52 ` Chen-Yu Tsai
[not found] ` <1403016777-15121-14-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-06-18 10:17 ` Maxime Ripard
2014-06-18 10:17 ` Maxime Ripard
2014-06-18 10:17 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625164107.GA19569@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=libv-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.