From: Shawn Guo <shawn.guo@freescale.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: <bhelgaas@google.com>, <r65037@freescale.com>, <marex@denx.de>,
<d.mueller@elsoft.ch>, <kernel@pengutronix.de>,
<linux-arm-kernel@lists.infradead.org>,
<linux-pci@vger.kernel.org>, <tharvey@gateworks.com>,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [RFC] PCI: pci-imx6: Add delay to workaround kernel hang
Date: Thu, 26 Jun 2014 11:12:49 +0800 [thread overview]
Message-ID: <20140626031247.GN2224@dragon> (raw)
In-Reply-To: <1403637507-9424-1-git-send-email-festevam@gmail.com>
On Tue, Jun 24, 2014 at 04:18:27PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> When the mx6 PCI conctroller is initialized in the bootloader we see a kernel
> hang inside imx6_add_pcie_port().
>
> Adding a 30ms delay allows the kernel to boot.
We may not want to add a random delay into the driver before we
understand the root cause of the issue.
Do you see this issue with FSL kernel?
Shawn
>
> Suggested-by: David Müller <d.mueller@elsoft.ch>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> I am happy to get feedback on how to properly fix this.
>
> Thanks
>
> drivers/pci/host/pci-imx6.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> index a568efa..669f771 100644
> --- a/drivers/pci/host/pci-imx6.c
> +++ b/drivers/pci/host/pci-imx6.c
> @@ -507,6 +507,8 @@ static int __init imx6_add_pcie_port(struct pcie_port *pp,
> pp->root_bus_nr = -1;
> pp->ops = &imx6_pcie_host_ops;
>
> + usleep_range(25000, 30000);
> +
> ret = dw_pcie_host_init(pp);
> if (ret) {
> dev_err(&pdev->dev, "failed to initialize host\n");
> --
> 1.8.3.2
>
WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] PCI: pci-imx6: Add delay to workaround kernel hang
Date: Thu, 26 Jun 2014 11:12:49 +0800 [thread overview]
Message-ID: <20140626031247.GN2224@dragon> (raw)
In-Reply-To: <1403637507-9424-1-git-send-email-festevam@gmail.com>
On Tue, Jun 24, 2014 at 04:18:27PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> When the mx6 PCI conctroller is initialized in the bootloader we see a kernel
> hang inside imx6_add_pcie_port().
>
> Adding a 30ms delay allows the kernel to boot.
We may not want to add a random delay into the driver before we
understand the root cause of the issue.
Do you see this issue with FSL kernel?
Shawn
>
> Suggested-by: David M?ller <d.mueller@elsoft.ch>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> I am happy to get feedback on how to properly fix this.
>
> Thanks
>
> drivers/pci/host/pci-imx6.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> index a568efa..669f771 100644
> --- a/drivers/pci/host/pci-imx6.c
> +++ b/drivers/pci/host/pci-imx6.c
> @@ -507,6 +507,8 @@ static int __init imx6_add_pcie_port(struct pcie_port *pp,
> pp->root_bus_nr = -1;
> pp->ops = &imx6_pcie_host_ops;
>
> + usleep_range(25000, 30000);
> +
> ret = dw_pcie_host_init(pp);
> if (ret) {
> dev_err(&pdev->dev, "failed to initialize host\n");
> --
> 1.8.3.2
>
next prev parent reply other threads:[~2014-06-26 3:13 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 19:18 [RFC] PCI: pci-imx6: Add delay to workaround kernel hang Fabio Estevam
2014-06-24 19:18 ` Fabio Estevam
2014-06-25 21:28 ` Marek Vasut
2014-06-25 21:28 ` Marek Vasut
2014-06-26 3:12 ` Shawn Guo [this message]
2014-06-26 3:12 ` Shawn Guo
2014-06-26 3:43 ` Fabio Estevam
2014-06-26 3:43 ` Fabio Estevam
2014-06-26 5:49 ` Shawn Guo
2014-06-26 5:49 ` Shawn Guo
2014-06-26 9:13 ` Marek Vasut
2014-06-26 9:13 ` Marek Vasut
2014-06-27 0:29 ` Tim Harvey
2014-06-27 0:29 ` Tim Harvey
2014-06-27 10:06 ` Hong-Xing.Zhu
2014-06-27 10:06 ` Hong-Xing.Zhu at freescale.com
2014-07-17 0:28 ` Tim Harvey
2014-07-17 0:28 ` Tim Harvey
2014-07-18 9:26 ` Lucas Stach
2014-07-18 9:26 ` Lucas Stach
2014-07-18 9:44 ` Marek Vasut
2014-07-18 9:44 ` Marek Vasut
2014-07-18 11:44 ` "David Müller (ELSOFT AG)"
2014-07-18 11:44 ` "David Müller (ELSOFT AG)"
2014-06-26 7:32 ` Juergen Borleis
2014-06-26 7:32 ` Juergen Borleis
2014-06-26 9:17 ` Marek Vasut
2014-06-26 9:17 ` Marek Vasut
2014-06-26 9:26 ` Juergen Borleis
2014-06-26 9:26 ` Juergen Borleis
2014-06-26 9:50 ` Marek Vasut
2014-06-26 9:50 ` Marek Vasut
2014-06-26 11:43 ` Fabio Estevam
2014-06-26 11:43 ` Fabio Estevam
2014-06-26 8:41 ` Lucas Stach
2014-06-26 8:41 ` Lucas Stach
2014-07-17 6:51 ` Uwe Kleine-König
2014-07-17 6:51 ` Uwe Kleine-König
2014-07-17 8:23 ` Marek Vasut
2014-07-17 8:23 ` Marek Vasut
2014-07-17 15:27 ` Shawn Guo
2014-07-17 15:27 ` Shawn Guo
2014-07-18 20:46 ` Marek Vasut
2014-07-18 20:46 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626031247.GN2224@dragon \
--to=shawn.guo@freescale.com \
--cc=bhelgaas@google.com \
--cc=d.mueller@elsoft.ch \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=marex@denx.de \
--cc=r65037@freescale.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.