From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Suman Anna <s-anna@ti.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
linux-arm-kernel@lists.infradead.org,
Aybuke Ozdemir <aybuke.147@gmail.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Omar Ramirez Luna <omar.ramirez@copitl.com>
Subject: Re: [PATCH 1/3] staging: tidspbridge: fix an erroneous removal of parentheses
Date: Thu, 26 Jun 2014 21:09:46 -0400 [thread overview]
Message-ID: <20140627010946.GA19029@kroah.com> (raw)
In-Reply-To: <1403587467-59876-2-git-send-email-s-anna@ti.com>
On Tue, Jun 24, 2014 at 12:24:25AM -0500, Suman Anna wrote:
> Commit 4a9fdbb (staging: core: tiomap3430.c Fix line over 80 characters.)
> erroneously removed the parentheses around the function pointer leading
> to the following build error (when enabling the build of TI DSP/Bridge
> driver):
>
> drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_monitor':
> drivers/staging/tidspbridge/core/tiomap3430.c:283:10: error: invalid type argument of unary '*' (have 'u32')
> make[3]: *** [drivers/staging/tidspbridge/core/tiomap3430.o] Error 1
>
> Fix this build error properly.
This shows that no one really uses this driver :(
Can't we just delete the thing?
I'll go queue this up for 3.16-final, thanks.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] staging: tidspbridge: fix an erroneous removal of parentheses
Date: Thu, 26 Jun 2014 21:09:46 -0400 [thread overview]
Message-ID: <20140627010946.GA19029@kroah.com> (raw)
In-Reply-To: <1403587467-59876-2-git-send-email-s-anna@ti.com>
On Tue, Jun 24, 2014 at 12:24:25AM -0500, Suman Anna wrote:
> Commit 4a9fdbb (staging: core: tiomap3430.c Fix line over 80 characters.)
> erroneously removed the parentheses around the function pointer leading
> to the following build error (when enabling the build of TI DSP/Bridge
> driver):
>
> drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_monitor':
> drivers/staging/tidspbridge/core/tiomap3430.c:283:10: error: invalid type argument of unary '*' (have 'u32')
> make[3]: *** [drivers/staging/tidspbridge/core/tiomap3430.o] Error 1
>
> Fix this build error properly.
This shows that no one really uses this driver :(
Can't we just delete the thing?
I'll go queue this up for 3.16-final, thanks.
greg k-h
next prev parent reply other threads:[~2014-06-27 4:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 5:24 [PATCH 0/3] Misc. DSPBridge build/boot fixes Suman Anna
2014-06-24 5:24 ` Suman Anna
2014-06-24 5:24 ` [PATCH 1/3] staging: tidspbridge: fix an erroneous removal of parentheses Suman Anna
2014-06-24 5:24 ` Suman Anna
2014-06-27 1:09 ` Greg Kroah-Hartman [this message]
2014-06-27 1:09 ` Greg Kroah-Hartman
2014-06-24 5:24 ` [PATCH 2/3] ARM: OMAP3: PRM/CM: Add back macros used by TI DSP/Bridge driver Suman Anna
2014-06-24 5:24 ` Suman Anna
2014-06-30 9:43 ` Paul Walmsley
2014-06-30 9:43 ` Paul Walmsley
2014-06-24 5:24 ` [PATCH 3/3] ARM: OMAP2+: create dsp device only on OMAP3 SoCs Suman Anna
2014-06-24 5:24 ` Suman Anna
2014-07-07 10:41 ` Tony Lindgren
2014-07-07 10:41 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140627010946.GA19029@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aybuke.147@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=omar.ramirez@copitl.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=s-anna@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.