From: Shawn Guo <shawn.guo@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: nm@ti.com, linaro-kernel@lists.linaro.org, mturquette@linaro.org,
linux-pm@vger.kernel.org, rjw@rjwysocki.net, t.figa@samsung.com,
sboyd@codeaurora.org, linux-kernel@vger.kernel.org,
thomas.ab@samsung.com, linux-arm-msm@vger.kernel.org,
arvind.chauhan@arm.com, spk.linux@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] cpufreq: cpu0: Extend support beyond CPU0
Date: Sat, 28 Jun 2014 22:52:54 +0800 [thread overview]
Message-ID: <20140628145253.GB7869@dragon> (raw)
In-Reply-To: <e9c0eef07745e561b9d12dcb50c3e2f7eb3e8880.1403684824.git.viresh.kumar@linaro.org>
On Wed, Jun 25, 2014 at 02:12:29PM +0530, Viresh Kumar wrote:
> cpufreq-cpu0 driver supports only platforms which have single clock line shared
> among all CPUs.
>
> We already have platforms where this limitation doesn't hold true.For example on
> Qualcomm's KRAIT all CPUs have separate clock line and so have separate
> policies.
>
> Instead of adding another driver for this (Stephen just tried that:
> https://lkml.org/lkml/2014/6/24/918), we must reuse cpufreq-cpu0 driver.
>
> cpufreq-cpu0 must be updated to break the assumption on which it is based (all
> cores sharing clock line) and this patch tries to do exactly that.
>
> As we don't have standard DT bindings to mention CPUs sharing clock-line, i.e.
> affected_cpus, this patch also have few limitations. Though easy to fix once we
> have proper bindings.
>
> Limitation: We only supports two types of platforms:
> - All CPUs sharing same clock line, existing user platforms
> - All CPUs have separate clock lines, KRAIT
>
> And so platforms which have multiple clusters with multiple CPUs per cluster
> aren't supported yet. We need proper bindings for that first.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> .../devicetree/bindings/cpufreq/cpufreq-cpu0.txt | 8 +-
> drivers/cpufreq/Kconfig | 5 +-
> drivers/cpufreq/cpufreq-cpu0.c | 280 +++++++++++++--------
> 3 files changed, 190 insertions(+), 103 deletions(-)
Hi Viresh,
Thanks for all the effort on maintaining and improving cpufreq-cpu0
driver. Your patch rewrote the most part of the driver, so I'd like to
hand over the driver to you. Please add yourself as the primary person
for MODULE_AUTHOR.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] cpufreq: cpu0: Extend support beyond CPU0
Date: Sat, 28 Jun 2014 22:52:54 +0800 [thread overview]
Message-ID: <20140628145253.GB7869@dragon> (raw)
In-Reply-To: <e9c0eef07745e561b9d12dcb50c3e2f7eb3e8880.1403684824.git.viresh.kumar@linaro.org>
On Wed, Jun 25, 2014 at 02:12:29PM +0530, Viresh Kumar wrote:
> cpufreq-cpu0 driver supports only platforms which have single clock line shared
> among all CPUs.
>
> We already have platforms where this limitation doesn't hold true.For example on
> Qualcomm's KRAIT all CPUs have separate clock line and so have separate
> policies.
>
> Instead of adding another driver for this (Stephen just tried that:
> https://lkml.org/lkml/2014/6/24/918), we must reuse cpufreq-cpu0 driver.
>
> cpufreq-cpu0 must be updated to break the assumption on which it is based (all
> cores sharing clock line) and this patch tries to do exactly that.
>
> As we don't have standard DT bindings to mention CPUs sharing clock-line, i.e.
> affected_cpus, this patch also have few limitations. Though easy to fix once we
> have proper bindings.
>
> Limitation: We only supports two types of platforms:
> - All CPUs sharing same clock line, existing user platforms
> - All CPUs have separate clock lines, KRAIT
>
> And so platforms which have multiple clusters with multiple CPUs per cluster
> aren't supported yet. We need proper bindings for that first.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> .../devicetree/bindings/cpufreq/cpufreq-cpu0.txt | 8 +-
> drivers/cpufreq/Kconfig | 5 +-
> drivers/cpufreq/cpufreq-cpu0.c | 280 +++++++++++++--------
> 3 files changed, 190 insertions(+), 103 deletions(-)
Hi Viresh,
Thanks for all the effort on maintaining and improving cpufreq-cpu0
driver. Your patch rewrote the most part of the driver, so I'd like to
hand over the driver to you. Please add yourself as the primary person
for MODULE_AUTHOR.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <rjw@rjwysocki.net>, <sboyd@codeaurora.org>,
<linaro-kernel@lists.linaro.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <arvind.chauhan@arm.com>,
<mturquette@linaro.org>, <linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>, <spk.linux@gmail.com>,
<thomas.ab@samsung.com>, <nm@ti.com>, <t.figa@samsung.com>
Subject: Re: [PATCH 2/2] cpufreq: cpu0: Extend support beyond CPU0
Date: Sat, 28 Jun 2014 22:52:54 +0800 [thread overview]
Message-ID: <20140628145253.GB7869@dragon> (raw)
In-Reply-To: <e9c0eef07745e561b9d12dcb50c3e2f7eb3e8880.1403684824.git.viresh.kumar@linaro.org>
On Wed, Jun 25, 2014 at 02:12:29PM +0530, Viresh Kumar wrote:
> cpufreq-cpu0 driver supports only platforms which have single clock line shared
> among all CPUs.
>
> We already have platforms where this limitation doesn't hold true.For example on
> Qualcomm's KRAIT all CPUs have separate clock line and so have separate
> policies.
>
> Instead of adding another driver for this (Stephen just tried that:
> https://lkml.org/lkml/2014/6/24/918), we must reuse cpufreq-cpu0 driver.
>
> cpufreq-cpu0 must be updated to break the assumption on which it is based (all
> cores sharing clock line) and this patch tries to do exactly that.
>
> As we don't have standard DT bindings to mention CPUs sharing clock-line, i.e.
> affected_cpus, this patch also have few limitations. Though easy to fix once we
> have proper bindings.
>
> Limitation: We only supports two types of platforms:
> - All CPUs sharing same clock line, existing user platforms
> - All CPUs have separate clock lines, KRAIT
>
> And so platforms which have multiple clusters with multiple CPUs per cluster
> aren't supported yet. We need proper bindings for that first.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> .../devicetree/bindings/cpufreq/cpufreq-cpu0.txt | 8 +-
> drivers/cpufreq/Kconfig | 5 +-
> drivers/cpufreq/cpufreq-cpu0.c | 280 +++++++++++++--------
> 3 files changed, 190 insertions(+), 103 deletions(-)
Hi Viresh,
Thanks for all the effort on maintaining and improving cpufreq-cpu0
driver. Your patch rewrote the most part of the driver, so I'd like to
hand over the driver to you. Please add yourself as the primary person
for MODULE_AUTHOR.
Shawn
next prev parent reply other threads:[~2014-06-28 14:52 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 8:42 [PATCH 0/2] cpufreq: cpu0: Extend support beyond CPU0 Viresh Kumar
2014-06-25 8:42 ` Viresh Kumar
2014-06-25 8:42 ` [PATCH 1/2] cpufreq: Add support for per-policy driver data Viresh Kumar
2014-06-25 8:42 ` Viresh Kumar
2014-06-25 8:42 ` [PATCH 2/2] cpufreq: cpu0: Extend support beyond CPU0 Viresh Kumar
2014-06-25 8:42 ` Viresh Kumar
2014-06-25 19:02 ` Stephen Boyd
2014-06-25 19:02 ` Stephen Boyd
2014-06-26 1:55 ` Viresh Kumar
2014-06-26 1:55 ` Viresh Kumar
2014-06-26 7:34 ` Viresh Kumar
2014-06-26 7:34 ` Viresh Kumar
2014-06-26 10:52 ` Viresh Kumar
2014-06-26 10:52 ` Viresh Kumar
2014-06-27 0:06 ` Stephen Boyd
2014-06-27 0:06 ` Stephen Boyd
2014-06-27 1:53 ` Mike Turquette
2014-06-27 1:53 ` Mike Turquette
2014-06-27 2:15 ` Viresh Kumar
2014-06-27 2:15 ` Viresh Kumar
2014-06-30 7:57 ` Viresh Kumar
2014-06-30 7:57 ` Viresh Kumar
2014-06-30 18:33 ` Rob Herring
2014-06-30 18:33 ` Rob Herring
2014-07-01 11:14 ` Viresh Kumar
2014-07-01 11:14 ` Viresh Kumar
2014-07-01 22:00 ` Mike Turquette
2014-07-01 22:00 ` Mike Turquette
2014-07-02 3:32 ` Viresh Kumar
2014-07-02 3:32 ` Viresh Kumar
2014-06-27 2:26 ` Viresh Kumar
2014-06-27 2:26 ` Viresh Kumar
2014-06-26 22:08 ` Mark Brown
2014-06-26 22:08 ` Mark Brown
2014-06-28 14:52 ` Shawn Guo [this message]
2014-06-28 14:52 ` Shawn Guo
2014-06-28 14:52 ` Shawn Guo
2014-06-30 4:50 ` Viresh Kumar
2014-06-30 4:50 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140628145253.GB7869@dragon \
--to=shawn.guo@linaro.org \
--cc=arvind.chauhan@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=spk.linux@gmail.com \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.