From: Rabin Vincent <rabin-66gdRtMMWGc@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Tomeu Vizoso
<tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [RFC 3/5] clk: use struct clk only for external API
Date: Mon, 30 Jun 2014 21:43:46 +0200 [thread overview]
Message-ID: <20140630194311.GA5167@dator> (raw)
In-Reply-To: <53ADF239.9050008-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Fri, Jun 27, 2014 at 04:37:45PM -0600, Stephen Warren wrote:
> On 06/27/2014 01:57 AM, Tomeu Vizoso wrote:
> > +struct clk {
> > + struct clk_core clk;
> > +};
>
> I'm confused why that field isn't a pointer instead.
It becomes a pointer in the following patch.
It's been a while since I created these patches, but IIRC I split it
this way because this patch was large and touching several drivers and
thus I wanted to make it do just the rename and keep core changes to a
minimum. Such as step may not be needed with Tomeu's series since it's
organized differently.
WARNING: multiple messages have this Message-ID (diff)
From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 3/5] clk: use struct clk only for external API
Date: Mon, 30 Jun 2014 21:43:46 +0200 [thread overview]
Message-ID: <20140630194311.GA5167@dator> (raw)
In-Reply-To: <53ADF239.9050008@wwwdotorg.org>
On Fri, Jun 27, 2014 at 04:37:45PM -0600, Stephen Warren wrote:
> On 06/27/2014 01:57 AM, Tomeu Vizoso wrote:
> > +struct clk {
> > + struct clk_core clk;
> > +};
>
> I'm confused why that field isn't a pointer instead.
It becomes a pointer in the following patch.
It's been a while since I created these patches, but IIRC I split it
this way because this patch was large and touching several drivers and
thus I wanted to make it do just the rename and keep core changes to a
minimum. Such as step may not be needed with Tomeu's series since it's
organized differently.
WARNING: multiple messages have this Message-ID (diff)
From: Rabin Vincent <rabin@rab.in>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Thierry Reding <thierry.reding@gmail.com>,
Mike Turquette <mturquette@linaro.org>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 3/5] clk: use struct clk only for external API
Date: Mon, 30 Jun 2014 21:43:46 +0200 [thread overview]
Message-ID: <20140630194311.GA5167@dator> (raw)
In-Reply-To: <53ADF239.9050008@wwwdotorg.org>
On Fri, Jun 27, 2014 at 04:37:45PM -0600, Stephen Warren wrote:
> On 06/27/2014 01:57 AM, Tomeu Vizoso wrote:
> > +struct clk {
> > + struct clk_core clk;
> > +};
>
> I'm confused why that field isn't a pointer instead.
It becomes a pointer in the following patch.
It's been a while since I created these patches, but IIRC I split it
this way because this patch was large and touching several drivers and
thus I wanted to make it do just the rename and keep core changes to a
minimum. Such as step may not be needed with Tomeu's series since it's
organized differently.
next prev parent reply other threads:[~2014-06-30 19:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 7:57 [RFC 0/5] Per-user clock constraints Tomeu Vizoso
2014-06-27 7:57 ` Tomeu Vizoso
2014-06-27 7:57 ` Tomeu Vizoso
2014-06-27 7:57 ` [RFC 1/5] clk: Add temporary mapping to the existing API Tomeu Vizoso
2014-06-27 7:57 ` Tomeu Vizoso
2014-06-27 7:57 ` [RFC 3/5] clk: use struct clk only for external API Tomeu Vizoso
2014-06-27 7:57 ` Tomeu Vizoso
[not found] ` <1403855872-14749-4-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-06-27 22:37 ` Stephen Warren
2014-06-27 22:37 ` Stephen Warren
2014-06-27 22:37 ` Stephen Warren
[not found] ` <53ADF239.9050008-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-30 19:43 ` Rabin Vincent [this message]
2014-06-30 19:43 ` Rabin Vincent
2014-06-30 19:43 ` Rabin Vincent
2014-06-27 7:57 ` [RFC 4/5] clk: per-user clock accounting for debug Tomeu Vizoso
2014-06-27 7:57 ` Tomeu Vizoso
2014-06-27 22:44 ` Stephen Warren
2014-06-27 22:44 ` Stephen Warren
[not found] ` <53ADF3C8.2060702-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-27 22:51 ` Stephen Warren
2014-06-27 22:51 ` Stephen Warren
2014-06-27 22:51 ` Stephen Warren
2014-06-30 19:49 ` Rabin Vincent
2014-06-30 19:49 ` Rabin Vincent
2014-06-30 19:49 ` Rabin Vincent
[not found] ` <1403855872-14749-1-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-06-27 7:57 ` [RFC 2/5] clk: Move all drivers to use internal API Tomeu Vizoso
2014-06-27 7:57 ` Tomeu Vizoso
2014-06-27 7:57 ` [RFC 5/5] clk: Add floor and ceiling constraints to clock rates Tomeu Vizoso
2014-06-27 7:57 ` Tomeu Vizoso
2014-06-27 7:57 ` Tomeu Vizoso
[not found] ` <1403855872-14749-6-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-06-27 22:57 ` Stephen Warren
2014-06-27 22:57 ` Stephen Warren
2014-06-27 22:57 ` Stephen Warren
2014-06-27 23:10 ` Thierry Reding
2014-06-27 23:10 ` Thierry Reding
2014-07-03 14:02 ` Tomeu Vizoso
2014-07-03 14:02 ` Tomeu Vizoso
2014-06-27 22:30 ` [RFC 0/5] Per-user clock constraints Stephen Warren
2014-06-27 22:30 ` Stephen Warren
2014-06-27 22:30 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630194311.GA5167@dator \
--to=rabin-66gdrtmmwgc@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.