From: Mel Gorman <mgorman@suse.de>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] shmem: fix init_page_accessed use to stop !PageLRU bug
Date: Mon, 30 Jun 2014 23:00:33 +0100 [thread overview]
Message-ID: <20140630220033.GS10819@suse.de> (raw)
In-Reply-To: <alpine.LSU.2.11.1406301405230.1096@eggly.anvils>
On Mon, Jun 30, 2014 at 02:08:11PM -0700, Hugh Dickins wrote:
> Under shmem swapping load, I sometimes hit the VM_BUG_ON_PAGE(!PageLRU)
> in isolate_lru_pages() at mm/vmscan.c:1281!
>
> Commit 2457aec63745 ("mm: non-atomically mark page accessed during page
> cache allocation where possible") looks like interrupted work-in-progress.
>
> mm/filemap.c's call to init_page_accessed() is fine, but not mm/shmem.c's
> - shmem_write_begin() is clearly wrong to use it after shmem_getpage(),
> when the page is always visible in radix_tree, and often already on LRU.
>
> Revert change to shmem_write_begin(), and use init_page_accessed() or
> mark_page_accessed() appropriately for SGP_WRITE in shmem_getpage_gfp().
>
> SGP_WRITE also covers shmem_symlink(), which did not mark_page_accessed()
> before; but since many other filesystems use [__]page_symlink(), which did
> and does mark the page accessed, consider this as rectifying an oversight.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] shmem: fix init_page_accessed use to stop !PageLRU bug
Date: Mon, 30 Jun 2014 23:00:33 +0100 [thread overview]
Message-ID: <20140630220033.GS10819@suse.de> (raw)
In-Reply-To: <alpine.LSU.2.11.1406301405230.1096@eggly.anvils>
On Mon, Jun 30, 2014 at 02:08:11PM -0700, Hugh Dickins wrote:
> Under shmem swapping load, I sometimes hit the VM_BUG_ON_PAGE(!PageLRU)
> in isolate_lru_pages() at mm/vmscan.c:1281!
>
> Commit 2457aec63745 ("mm: non-atomically mark page accessed during page
> cache allocation where possible") looks like interrupted work-in-progress.
>
> mm/filemap.c's call to init_page_accessed() is fine, but not mm/shmem.c's
> - shmem_write_begin() is clearly wrong to use it after shmem_getpage(),
> when the page is always visible in radix_tree, and often already on LRU.
>
> Revert change to shmem_write_begin(), and use init_page_accessed() or
> mark_page_accessed() appropriately for SGP_WRITE in shmem_getpage_gfp().
>
> SGP_WRITE also covers shmem_symlink(), which did not mark_page_accessed()
> before; but since many other filesystems use [__]page_symlink(), which did
> and does mark the page accessed, consider this as rectifying an oversight.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2014-06-30 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 21:08 [PATCH 1/2] shmem: fix init_page_accessed use to stop !PageLRU bug Hugh Dickins
2014-06-30 21:08 ` Hugh Dickins
2014-06-30 21:09 ` [PATCH 2/2] mm: replace init_page_accessed by __SetPageReferenced Hugh Dickins
2014-06-30 21:09 ` Hugh Dickins
2014-06-30 21:59 ` Mel Gorman
2014-06-30 21:59 ` Mel Gorman
2014-06-30 22:00 ` Mel Gorman [this message]
2014-06-30 22:00 ` [PATCH 1/2] shmem: fix init_page_accessed use to stop !PageLRU bug Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630220033.GS10819@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.