From: Catalin Marinas <catalin.marinas@arm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Wim Van Sebroeck <wim@iguana.be>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Will Deacon <Will.Deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
Heiko Stuebner <heiko@sntech.de>,
Jonas Jensen <jonas.jensen@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [RFC PATCH 0/6] kernel: Add support for restart notifier call chain
Date: Tue, 1 Jul 2014 18:08:53 +0100 [thread overview]
Message-ID: <20140701170853.GX18313@arm.com> (raw)
In-Reply-To: <53B2BB74.7050300@roeck-us.net>
On Tue, Jul 01, 2014 at 02:45:24PM +0100, Guenter Roeck wrote:
> On 07/01/2014 04:24 AM, Catalin Marinas wrote:
> > On Mon, Jun 30, 2014 at 09:28:51PM +0100, Guenter Roeck wrote:
> >> What is restart-poweroff supposed to do in the first place, and why
> >> doesn't it call machine_restart() ? If it is what I think it is, ie
> >> a fallback for pm_power_off, it could be made generic and does not
> >> really have to depend on ARM.
> >
> > I think this one pretends to do a power-off via restart. It could call
> > machine_restart() but this only passes the default reboot_mode to
> > arm_pm_restart().
>
> Unless one sets reboot_mode first. See my proposed patch in
> https://lkml.org/lkml/2014/6/30/792.
It looks fine to me.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/6] kernel: Add support for restart notifier call chain
Date: Tue, 1 Jul 2014 18:08:53 +0100 [thread overview]
Message-ID: <20140701170853.GX18313@arm.com> (raw)
In-Reply-To: <53B2BB74.7050300@roeck-us.net>
On Tue, Jul 01, 2014 at 02:45:24PM +0100, Guenter Roeck wrote:
> On 07/01/2014 04:24 AM, Catalin Marinas wrote:
> > On Mon, Jun 30, 2014 at 09:28:51PM +0100, Guenter Roeck wrote:
> >> What is restart-poweroff supposed to do in the first place, and why
> >> doesn't it call machine_restart() ? If it is what I think it is, ie
> >> a fallback for pm_power_off, it could be made generic and does not
> >> really have to depend on ARM.
> >
> > I think this one pretends to do a power-off via restart. It could call
> > machine_restart() but this only passes the default reboot_mode to
> > arm_pm_restart().
>
> Unless one sets reboot_mode first. See my proposed patch in
> https://lkml.org/lkml/2014/6/30/792.
It looks fine to me.
--
Catalin
next prev parent reply other threads:[~2014-07-01 17:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 19:11 [RFC PATCH 0/6] kernel: Add support for restart notifier call chain Guenter Roeck
2014-06-30 19:11 ` Guenter Roeck
2014-06-30 19:11 ` [RFC PATCH 1/6] " Guenter Roeck
2014-06-30 19:11 ` Guenter Roeck
2014-06-30 19:11 ` [RFC PATCH 2/6] arm64: Support restart through " Guenter Roeck
2014-06-30 19:11 ` Guenter Roeck
2014-07-01 7:26 ` Maxime Ripard
2014-07-01 7:26 ` Maxime Ripard
2014-07-01 13:39 ` Guenter Roeck
2014-07-01 13:39 ` Guenter Roeck
2014-06-30 19:11 ` [RFC PATCH 3/6] arm: " Guenter Roeck
2014-06-30 19:11 ` Guenter Roeck
2014-06-30 19:55 ` Russell King - ARM Linux
2014-06-30 19:55 ` Russell King - ARM Linux
2014-06-30 19:11 ` [RFC PATCH 4/6] watchdog: moxart: Register restart handler with restart notifier Guenter Roeck
2014-06-30 19:11 ` Guenter Roeck
2014-06-30 19:11 ` [RFC PATCH 5/6] watchdog: alim7101: " Guenter Roeck
2014-06-30 19:11 ` Guenter Roeck
2014-06-30 19:11 ` [RFC PATCH 6/6] arm/arm64: Unexport restart handlers Guenter Roeck
2014-06-30 19:11 ` Guenter Roeck
2014-06-30 19:59 ` [RFC PATCH 0/6] kernel: Add support for restart notifier call chain Russell King - ARM Linux
2014-06-30 19:59 ` Russell King - ARM Linux
2014-06-30 20:28 ` Guenter Roeck
2014-06-30 20:28 ` Guenter Roeck
2014-07-01 11:24 ` Catalin Marinas
2014-07-01 11:24 ` Catalin Marinas
2014-07-01 13:45 ` Guenter Roeck
2014-07-01 13:45 ` Guenter Roeck
2014-07-01 17:08 ` Catalin Marinas [this message]
2014-07-01 17:08 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701170853.GX18313@arm.com \
--to=catalin.marinas@arm.com \
--cc=Will.Deacon@arm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=heiko@sntech.de \
--cc=jonas.jensen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=maxime.ripard@free-electrons.com \
--cc=mingo@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.