From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [RFC PATCH] dlm: Remove unused conf from lm_grant
Date: Tue, 1 Jul 2014 12:22:13 -0500 [thread overview]
Message-ID: <20140701172213.GD32565@redhat.com> (raw)
In-Reply-To: <1781051691.1348978.1404234992108.JavaMail.zimbra@redhat.com>
On Tue, Jul 01, 2014 at 01:16:32PM -0400, Bob Peterson wrote:
> ----- Original Message -----
> > On Tue, Jul 01, 2014 at 10:43:13AM -0400, Jeff Layton wrote:
> > > On Tue, 01 Jul 2014 06:20:10 -0700
> > > Joe Perches <joe@perches.com> wrote:
> > >
> > > > While doing a bit of adding argument names to fs.h,
> > > > I looked at lm_grant and it seems the 2nd argument
> > > > is always NULL.
> > > >
> > > > How about removing it?
> > > >
> > > > This doesn't apply as it depends on some other patches
> > > > but it should be clear enough...
> > > >
> > >
> > > ACK on the general idea from my standpoint. Anything that simplifies
> > > the file locking interfaces is a good thing, particularly the deferred
> > > locking code.
> >
> > Fine with me. I'd be happy to remove all the deferred locking code from
> > dlm; it never really worked.
> GFS2 uses deferred locks, at the very least in its direct_io path
> (gfs2_direct_IO in aops.c). So AFAIK we can't remove THAT without a certain
> amount of pain. Steve is on vacation / holiday this week, but he will
> be back on Thursday and Friday (which is a holiday).
This is about deferred file locks from NFS, not gfs2's "deferred" lock mode.
Dave
WARNING: multiple messages have this Message-ID (diff)
From: David Teigland <teigland@redhat.com>
To: Bob Peterson <rpeterso@redhat.com>
Cc: Jeff Layton <jlayton@poochiereds.net>,
cluster-devel@redhat.com, linux-nfs@vger.kernel.org,
Trond Myklebust <trond.myklebust@primarydata.com>,
linux-kernel@vger.kernel.org,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-fsdevel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [Cluster-devel] [RFC PATCH] dlm: Remove unused conf from lm_grant
Date: Tue, 1 Jul 2014 12:22:13 -0500 [thread overview]
Message-ID: <20140701172213.GD32565@redhat.com> (raw)
In-Reply-To: <1781051691.1348978.1404234992108.JavaMail.zimbra@redhat.com>
On Tue, Jul 01, 2014 at 01:16:32PM -0400, Bob Peterson wrote:
> ----- Original Message -----
> > On Tue, Jul 01, 2014 at 10:43:13AM -0400, Jeff Layton wrote:
> > > On Tue, 01 Jul 2014 06:20:10 -0700
> > > Joe Perches <joe@perches.com> wrote:
> > >
> > > > While doing a bit of adding argument names to fs.h,
> > > > I looked at lm_grant and it seems the 2nd argument
> > > > is always NULL.
> > > >
> > > > How about removing it?
> > > >
> > > > This doesn't apply as it depends on some other patches
> > > > but it should be clear enough...
> > > >
> > >
> > > ACK on the general idea from my standpoint. Anything that simplifies
> > > the file locking interfaces is a good thing, particularly the deferred
> > > locking code.
> >
> > Fine with me. I'd be happy to remove all the deferred locking code from
> > dlm; it never really worked.
> GFS2 uses deferred locks, at the very least in its direct_io path
> (gfs2_direct_IO in aops.c). So AFAIK we can't remove THAT without a certain
> amount of pain. Steve is on vacation / holiday this week, but he will
> be back on Thursday and Friday (which is a holiday).
This is about deferred file locks from NFS, not gfs2's "deferred" lock mode.
Dave
WARNING: multiple messages have this Message-ID (diff)
From: David Teigland <teigland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Bob Peterson <rpeterso-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Jeff Layton <jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org>,
cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Trond Myklebust
<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"J. Bruce Fields"
<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [Cluster-devel] [RFC PATCH] dlm: Remove unused conf from lm_grant
Date: Tue, 1 Jul 2014 12:22:13 -0500 [thread overview]
Message-ID: <20140701172213.GD32565@redhat.com> (raw)
In-Reply-To: <1781051691.1348978.1404234992108.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Tue, Jul 01, 2014 at 01:16:32PM -0400, Bob Peterson wrote:
> ----- Original Message -----
> > On Tue, Jul 01, 2014 at 10:43:13AM -0400, Jeff Layton wrote:
> > > On Tue, 01 Jul 2014 06:20:10 -0700
> > > Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> wrote:
> > >
> > > > While doing a bit of adding argument names to fs.h,
> > > > I looked at lm_grant and it seems the 2nd argument
> > > > is always NULL.
> > > >
> > > > How about removing it?
> > > >
> > > > This doesn't apply as it depends on some other patches
> > > > but it should be clear enough...
> > > >
> > >
> > > ACK on the general idea from my standpoint. Anything that simplifies
> > > the file locking interfaces is a good thing, particularly the deferred
> > > locking code.
> >
> > Fine with me. I'd be happy to remove all the deferred locking code from
> > dlm; it never really worked.
> GFS2 uses deferred locks, at the very least in its direct_io path
> (gfs2_direct_IO in aops.c). So AFAIK we can't remove THAT without a certain
> amount of pain. Steve is on vacation / holiday this week, but he will
> be back on Thursday and Friday (which is a holiday).
This is about deferred file locks from NFS, not gfs2's "deferred" lock mode.
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-01 17:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 13:20 [Cluster-devel] [RFC PATCH] dlm: Remove unused conf from lm_grant Joe Perches
2014-07-01 13:20 ` Joe Perches
2014-07-01 14:43 ` [Cluster-devel] " Jeff Layton
2014-07-01 14:43 ` Jeff Layton
2014-07-01 14:43 ` Jeff Layton
2014-07-01 16:46 ` [Cluster-devel] " David Teigland
2014-07-01 16:46 ` David Teigland
2014-07-01 16:46 ` David Teigland
2014-07-01 17:16 ` [Cluster-devel] " Bob Peterson
2014-07-01 17:16 ` Bob Peterson
2014-07-01 17:22 ` David Teigland [this message]
2014-07-01 17:22 ` David Teigland
2014-07-01 17:22 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701172213.GD32565@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.