From: Marcelo Tosatti <mtosatti@redhat.com>
To: Gleb Natapov <gleb@minantech.com>
Cc: kvm@vger.kernel.org, ak@linux.intel.com, pbonzini@redhat.com,
xiaoguangrong@linux.vnet.ibm.com, avi@cloudius-systems.com
Subject: Re: [patch 4/5] KVM: MMU: reload request from GET_DIRTY_LOG path
Date: Tue, 1 Jul 2014 14:50:10 -0300 [thread overview]
Message-ID: <20140701175010.GA10927@amt.cnet> (raw)
In-Reply-To: <20140701062719.GK18167@minantech.com>
On Tue, Jul 01, 2014 at 09:27:19AM +0300, Gleb Natapov wrote:
> > The vcpu will never see a read-only spte because the VM-exit (due to
> > IPI) guarantees vcpu is outside of guest mode _before_ it is write
> > protected.
> Right. Now I see why you absolutely have to send IPI in mmu_reload_pinned_vcpus()
> before marking pte as read only. And kvm->mmu_lock is what will prevent vcpu from
> re-entering guest mode again before pte is marked read only, right?
Yes.
> > So i ask you: do you still hold the "current approach should be
> > improved" position ?
> >
> As I said IMO what I proposed is much simpler and not as tricky as what you have here.
> It also has an advantage of not slowing down next guest entry after GET_DIRTY_LOG because
> it does not require mmu reload and page_faulting in pinned pages.
Ok sure.
next prev parent reply other threads:[~2014-07-01 17:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 23:12 [patch 0/5] KVM: support for pinning sptes mtosatti
2014-06-18 23:12 ` [patch 1/5] KVM: x86: add pinned parameter to page_fault methods mtosatti
2014-06-18 23:12 ` [patch 2/5] KVM: MMU: allow pinning spte translations (TDP-only) mtosatti
2014-06-19 7:21 ` Gleb Natapov
2014-06-19 19:22 ` Marcelo Tosatti
2014-06-20 10:09 ` Gleb Natapov
2014-06-30 20:46 ` Marcelo Tosatti
2014-06-30 22:00 ` Andi Kleen
2014-06-19 8:01 ` Avi Kivity
2014-06-19 14:06 ` Andi Kleen
2014-06-19 18:26 ` Marcelo Tosatti
2014-06-22 13:35 ` Avi Kivity
2014-07-09 13:25 ` Marcelo Tosatti
2014-07-02 0:58 ` Nadav Amit
2014-06-18 23:12 ` [patch 3/5] KVM: MMU: notifiers support for pinned sptes mtosatti
2014-06-19 6:48 ` Gleb Natapov
2014-06-19 18:28 ` Marcelo Tosatti
2014-06-20 10:11 ` Gleb Natapov
2014-06-18 23:12 ` [patch 4/5] KVM: MMU: reload request from GET_DIRTY_LOG path mtosatti
2014-06-19 8:17 ` Gleb Natapov
2014-06-19 18:40 ` Marcelo Tosatti
2014-06-20 10:46 ` Gleb Natapov
2014-06-30 20:59 ` Marcelo Tosatti
2014-07-01 6:27 ` Gleb Natapov
2014-07-01 17:50 ` Marcelo Tosatti [this message]
2014-06-18 23:12 ` [patch 5/5] KVM: MMU: pinned sps are not candidates for deletion mtosatti
2014-06-19 1:44 ` [patch 0/5] KVM: support for pinning sptes Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701175010.GA10927@amt.cnet \
--to=mtosatti@redhat.com \
--cc=ak@linux.intel.com \
--cc=avi@cloudius-systems.com \
--cc=gleb@minantech.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.