All of lore.kernel.org
 help / color / mirror / Atom feed
From: boris.brezillon@free-electrons.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/33] clk: at91: main: warn when the main crystal frequency is not set
Date: Wed, 2 Jul 2014 10:18:11 +0200	[thread overview]
Message-ID: <20140702101811.2f2a507e@bbrezillon> (raw)
In-Reply-To: <1404223962-30471-4-git-send-email-alexandre.belloni@free-electrons.com>

On Tue,  1 Jul 2014 16:12:12 +0200
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:

> When the main crystal frequency is not set, the main clock is
> approximated using the MAINF value in the CKGR_MCFR register. Warn
> the user in that case.
> 
> Signed-off-by: Alexandre Belloni
> <alexandre.belloni@free-electrons.com> ---

Acked-by: Boris BREZILLON <boris.brezillon@overkiz.com>

Mike, do you want me to take this patch and send you a pull request, or
should I let you take this one directly ?

Best Regards,

Boris

>  drivers/clk/at91/clk-main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/at91/clk-main.c b/drivers/clk/at91/clk-main.c
> index 733306131b99..59fa3cc96c9e 100644
> --- a/drivers/clk/at91/clk-main.c
> +++ b/drivers/clk/at91/clk-main.c
> @@ -388,6 +388,7 @@ static unsigned long clk_main_recalc_rate(struct
> at91_pmc *pmc, if (parent_rate)
>  		return parent_rate;
>  
> +	pr_warn("Main crystal frequency not set, using approximate
> value\n"); tmp = pmc_read(pmc, AT91_CKGR_MCFR);
>  	if (!(tmp & AT91_PMC_MAINRDY))
>  		return 0;



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Boris BREZILLON <boris.brezillon@free-electrons.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Mike Turquette <mturquette@linaro.org>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/33] clk: at91: main: warn when the main crystal frequency is not set
Date: Wed, 2 Jul 2014 10:18:11 +0200	[thread overview]
Message-ID: <20140702101811.2f2a507e@bbrezillon> (raw)
In-Reply-To: <1404223962-30471-4-git-send-email-alexandre.belloni@free-electrons.com>

On Tue,  1 Jul 2014 16:12:12 +0200
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:

> When the main crystal frequency is not set, the main clock is
> approximated using the MAINF value in the CKGR_MCFR register. Warn
> the user in that case.
> 
> Signed-off-by: Alexandre Belloni
> <alexandre.belloni@free-electrons.com> ---

Acked-by: Boris BREZILLON <boris.brezillon@overkiz.com>

Mike, do you want me to take this patch and send you a pull request, or
should I let you take this one directly ?

Best Regards,

Boris

>  drivers/clk/at91/clk-main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/at91/clk-main.c b/drivers/clk/at91/clk-main.c
> index 733306131b99..59fa3cc96c9e 100644
> --- a/drivers/clk/at91/clk-main.c
> +++ b/drivers/clk/at91/clk-main.c
> @@ -388,6 +388,7 @@ static unsigned long clk_main_recalc_rate(struct
> at91_pmc *pmc, if (parent_rate)
>  		return parent_rate;
>  
> +	pr_warn("Main crystal frequency not set, using approximate
> value\n"); tmp = pmc_read(pmc, AT91_CKGR_MCFR);
>  	if (!(tmp & AT91_PMC_MAINRDY))
>  		return 0;



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2014-07-02  8:18 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 14:12 [PATCH 00/33] ARM: at91: Switch remaining SoCs and boards to CCF Alexandre Belloni
2014-07-01 14:12 ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 01/33] Documentation: dt: document all the atmel pmc compatibles Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-02  8:10   ` Boris BREZILLON
2014-07-02  8:10     ` Boris BREZILLON
2014-07-01 14:12 ` [PATCH 02/33] ARM: at91/dt: ariag25: define crystals frequencies Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 03/33] clk: at91: main: warn when the main crystal frequency is not set Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-02  8:18   ` Boris BREZILLON [this message]
2014-07-02  8:18     ` Boris BREZILLON
2014-07-02  8:23     ` Boris BREZILLON
2014-07-02  8:23       ` Boris BREZILLON
2014-07-02 16:38     ` Mike Turquette
2014-07-02 16:38       ` Mike Turquette
2014-07-02 16:55       ` Boris BREZILLON
2014-07-02 16:55         ` Boris BREZILLON
2014-07-01 14:12 ` [PATCH 04/33] ARM: at91: prepare common clk transition for rm9200 Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-02  8:20   ` Boris BREZILLON
2014-07-02  8:20     ` Boris BREZILLON
2014-07-01 14:12 ` [PATCH 05/33] ARM: at91/dt: rm9200: define clocks Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-02  8:04   ` Boris BREZILLON
2014-07-02  8:04     ` Boris BREZILLON
2014-07-01 14:12 ` [PATCH 06/33] ARM: at91: move at91rm9200 SoC to the CCF Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-02  8:25   ` Boris BREZILLON
2014-07-02  8:25     ` Boris BREZILLON
2014-07-01 14:12 ` [PATCH 07/33] ARM: at91/dt: at91rm9200ek: define crystals frequencies Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 08/33] ARM: at91: prepare common clk transition for sam9260 Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 09/33] ARM: at91/dt: sam9260: define clocks Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 10/33] ARM: at91/dt: sam9g20: " Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 11/33] ARM: at91: move at91sam9260 SoCs to the CCF Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 12/33] ARM: at91/dt: at91sam9g20ek: define crystals frequencies Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 13/33] ARM: at91/dt: foxg20: " Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 14/33] ARM: at91/dt: usb_a9260: " Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 15/33] ARM: at91/dt: tny_a9260: " Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 16/33] ARM: at91/dt: qil_a9260: " Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 17/33] ARM: at91/dt: mpa1600: define crytals frequencies Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 18/33] ARM: at91/dt: ge863-pro3: define crystals frequencies Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 19/33] ARM: at91/dt: ethernut5: " Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 20/33] ARM: at91/dt: animeo_ip: " Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 21/33] ARM: at91/dt: kizbox: define main crystal frequency Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 22/33] ARM: at91: prepare common clk transition for sam9g45 Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 23/33] ARM: at91/dt: sam9g45: define clocks Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 24/33] ARM: at91: move at91sam9g45 SoC to the CCF Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 25/33] ARM: at91/dt: sam9m10g45ek: define crystals frequencies Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 26/33] ARM: at91/dt: pm9g45: " Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 27/33] ARM: at91/dt: cosino define " Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 28/33] ARM: at91: prepare common clk transition for sam9263 Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 29/33] ARM: at91/dt: sam9263: define clocks Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 30/33] ARM: at91: move at91sam9263 SoC to the CCF Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 31/33] ARM: at91/dt: sam9263ek: define crystals frequencies Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 32/33] ARM: at91/dt: tny_a9263: " Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 14:12 ` [PATCH 33/33] ARM: at91/dt: usb_a9263: " Alexandre Belloni
2014-07-01 14:12   ` Alexandre Belloni
2014-07-01 16:35 ` [PATCH 00/33] ARM: at91: Switch remaining SoCs and boards to CCF Arnd Bergmann
2014-07-01 16:35   ` Arnd Bergmann
2014-07-01 16:48   ` Alexandre Belloni
2014-07-01 16:48     ` Alexandre Belloni
2014-07-01 17:01     ` Arnd Bergmann
2014-07-01 17:01       ` Arnd Bergmann
2014-07-01 17:56       ` Alexandre Belloni
2014-07-01 17:56         ` Alexandre Belloni
2014-07-01 20:02         ` Arnd Bergmann
2014-07-01 20:02           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140702101811.2f2a507e@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.