From: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
To: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v2 5/5] efi: efistub: convert into static library
Date: Wed, 2 Jul 2014 12:15:28 +0100 [thread overview]
Message-ID: <20140702111528.GL7539@console-pimps.org> (raw)
In-Reply-To: <1403792617-25792-6-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Thu, 26 Jun, at 04:23:37PM, Ard Biesheuvel wrote:
> This patch changes both x86 and arm64 efistub implementations from #including
> shared .c files under drivers/firmware/efi to building the shared code as a
> static library.
>
> The x86 code uses a stub built into the boot executable which uncompresses the
> kernel at boot time. In this case, the library is linked into the decompressor.
>
> In the arm64 case, the stub is part of the kernel proper so the library is
> linked into the kernel proper as well.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
OK, this breaks the ia64 build because of the following...
/drivers/firmware/efi/libstub/efi-stub-helper.c:14:21: fatal error: asm/efi.h: No such file or directory
> diff --git a/drivers/firmware/efi/Makefile b/drivers/firmware/efi/Makefile
> index e1096539eedb..d9abdbc962f1 100644
> --- a/drivers/firmware/efi/Makefile
> +++ b/drivers/firmware/efi/Makefile
> @@ -1,7 +1,7 @@
> #
> # Makefile for linux kernel
> #
> -obj-$(CONFIG_EFI) += efi.o vars.o
> +obj-$(CONFIG_EFI) += efi.o vars.o libstub/
> obj-$(CONFIG_EFI_VARS) += efivars.o
> obj-$(CONFIG_EFI_VARS_PSTORE) += efi-pstore.o
> obj-$(CONFIG_UEFI_CPER) += cper.o
I guess what we need is CONFIG_EFI_LIBSTUB selected by both
CONFIG_EFI_STUB (for x86) and CONFIG_EFI_ARMSTUB (for arm64)? e.g.
obj-$(CONFIG_EFI_LIBSTUB) libstub/
--
Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: matt@console-pimps.org (Matt Fleming)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] efi: efistub: convert into static library
Date: Wed, 2 Jul 2014 12:15:28 +0100 [thread overview]
Message-ID: <20140702111528.GL7539@console-pimps.org> (raw)
In-Reply-To: <1403792617-25792-6-git-send-email-ard.biesheuvel@linaro.org>
On Thu, 26 Jun, at 04:23:37PM, Ard Biesheuvel wrote:
> This patch changes both x86 and arm64 efistub implementations from #including
> shared .c files under drivers/firmware/efi to building the shared code as a
> static library.
>
> The x86 code uses a stub built into the boot executable which uncompresses the
> kernel at boot time. In this case, the library is linked into the decompressor.
>
> In the arm64 case, the stub is part of the kernel proper so the library is
> linked into the kernel proper as well.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
OK, this breaks the ia64 build because of the following...
/drivers/firmware/efi/libstub/efi-stub-helper.c:14:21: fatal error: asm/efi.h: No such file or directory
> diff --git a/drivers/firmware/efi/Makefile b/drivers/firmware/efi/Makefile
> index e1096539eedb..d9abdbc962f1 100644
> --- a/drivers/firmware/efi/Makefile
> +++ b/drivers/firmware/efi/Makefile
> @@ -1,7 +1,7 @@
> #
> # Makefile for linux kernel
> #
> -obj-$(CONFIG_EFI) += efi.o vars.o
> +obj-$(CONFIG_EFI) += efi.o vars.o libstub/
> obj-$(CONFIG_EFI_VARS) += efivars.o
> obj-$(CONFIG_EFI_VARS_PSTORE) += efi-pstore.o
> obj-$(CONFIG_UEFI_CPER) += cper.o
I guess what we need is CONFIG_EFI_LIBSTUB selected by both
CONFIG_EFI_STUB (for x86) and CONFIG_EFI_ARMSTUB (for arm64)? e.g.
obj-$(CONFIG_EFI_LIBSTUB) libstub/
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-07-02 11:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 14:23 [PATCH v2 0/5] efistub: convert into static library Ard Biesheuvel
2014-06-26 14:23 ` Ard Biesheuvel
[not found] ` <1403792617-25792-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-06-26 14:23 ` [PATCH v2 1/5] efi/arm64: avoid EFI_ERROR as a generic return code Ard Biesheuvel
2014-06-26 14:23 ` Ard Biesheuvel
2014-06-26 14:23 ` [PATCH v2 2/5] efi/x86: efistub: move shared dependencies to <asm/efi.h> Ard Biesheuvel
2014-06-26 14:23 ` Ard Biesheuvel
[not found] ` <1403792617-25792-3-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-07-02 12:59 ` Mark Salter
2014-07-02 12:59 ` Mark Salter
[not found] ` <1404305996.19665.7.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-07-02 13:02 ` Ard Biesheuvel
2014-07-02 13:02 ` Ard Biesheuvel
2014-06-26 14:23 ` [PATCH v2 3/5] efi/arm64: " Ard Biesheuvel
2014-06-26 14:23 ` Ard Biesheuvel
2014-06-26 14:23 ` [PATCH v2 4/5] efi: efistub: refactor stub components Ard Biesheuvel
2014-06-26 14:23 ` Ard Biesheuvel
[not found] ` <1403792617-25792-5-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-07-01 15:11 ` Matt Fleming
2014-07-01 15:11 ` Matt Fleming
[not found] ` <20140701151130.GF7539-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-07-01 15:18 ` Ard Biesheuvel
2014-07-01 15:18 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9tY7RqVXdWejwOPnpBTX0S5M9QxBH2te71kpysOV3vWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-01 15:20 ` Ard Biesheuvel
2014-07-01 15:20 ` Ard Biesheuvel
[not found] ` <CAKv+Gu8sHpHNEJhDrrJcN12rVrhRgprzmNeJ_BoMCbL+Gh2-NQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-01 16:22 ` Matt Fleming
2014-07-01 16:22 ` Matt Fleming
2014-06-26 14:23 ` [PATCH v2 5/5] efi: efistub: convert into static library Ard Biesheuvel
2014-06-26 14:23 ` Ard Biesheuvel
[not found] ` <1403792617-25792-6-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-07-02 11:15 ` Matt Fleming [this message]
2014-07-02 11:15 ` Matt Fleming
[not found] ` <20140702111528.GL7539-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-07-02 11:23 ` Ard Biesheuvel
2014-07-02 11:23 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9N_p49603oy0rKaq+G6sX+GS5ueSfJ2B=Yh7DrF301Cg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-02 11:49 ` Ard Biesheuvel
2014-07-02 11:49 ` Ard Biesheuvel
2014-07-01 18:39 ` [PATCH v2 0/5] " Matt Fleming
2014-07-01 18:39 ` Matt Fleming
[not found] ` <20140701183906.GH7539-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-07-01 18:55 ` Ard Biesheuvel
2014-07-01 18:55 ` Ard Biesheuvel
[not found] ` <CAKv+Gu8eN4s9V6=mmQFpMDKuuMRE0y5T6pxk27=BLMFRX1O57w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-01 19:01 ` Matt Fleming
2014-07-01 19:01 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702111528.GL7539@console-pimps.org \
--to=matt-hnk1s37rvnbexh+ff434mdi2o/jbrioy@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.