From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: 'Rickard Strandqvist'
<rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>,
'Grant Likely'
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
'Rob Herring' <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
'Leilei Shang' <shangll-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
'Peter Korsgaard' <peter-+2lRwdCCLRT2eFz/2MeuCQ@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc
Date: Thu, 3 Jul 2014 10:41:09 +0200 [thread overview]
Message-ID: <20140703084108.GA3012@katana> (raw)
In-Reply-To: <003601cf9660$83368990$89a39cb0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
Hi Rickard, hi Jingoo,
> I also trust Wolfram. He is one of the most important and active
> person for Linux kernel.
Oh, thanks. I'm flattered :)
> Wolfram may mean devm_ioremap_resource(), not devm_ioremap().
Yes, you are right. Sorry for missing this detail when suggesting an
example to convert to devm_*. devm_ioremap_resource should be favoured
over devm_ioremap.
> 1. devm_ioremap_resource(): IS_ERR() can be used.
>
> dev->virtbase = devm_ioremap_resource(&adev->dev, res));
> if (IS_ERR(dev->virtbase)) {
This is correct and preferred.
BTW I don't care much about splitting up the patch as long as the commit
message says that the original bug is a motivation to swicth to devm_*.
Thanks Rickard for picking up the task, and thanks Jingoo for reviewing.
Kind regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Rickard Strandqvist'" <rickard_strandqvist@spectrumdigital.se>,
"'Grant Likely'" <grant.likely@linaro.org>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Leilei Shang'" <shangll@marvell.com>,
"'Peter Korsgaard'" <peter@korsgaard.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc
Date: Thu, 3 Jul 2014 10:41:09 +0200 [thread overview]
Message-ID: <20140703084108.GA3012@katana> (raw)
In-Reply-To: <003601cf9660$83368990$89a39cb0$%han@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
Hi Rickard, hi Jingoo,
> I also trust Wolfram. He is one of the most important and active
> person for Linux kernel.
Oh, thanks. I'm flattered :)
> Wolfram may mean devm_ioremap_resource(), not devm_ioremap().
Yes, you are right. Sorry for missing this detail when suggesting an
example to convert to devm_*. devm_ioremap_resource should be favoured
over devm_ioremap.
> 1. devm_ioremap_resource(): IS_ERR() can be used.
>
> dev->virtbase = devm_ioremap_resource(&adev->dev, res));
> if (IS_ERR(dev->virtbase)) {
This is correct and preferred.
BTW I don't care much about splitting up the patch as long as the commit
message says that the original bug is a motivation to swicth to devm_*.
Thanks Rickard for picking up the task, and thanks Jingoo for reviewing.
Kind regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-03 8:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 23:28 [PATCH v2] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc Rickard Strandqvist
2014-06-29 23:28 ` Rickard Strandqvist
2014-06-29 23:28 ` Rickard Strandqvist
2014-06-30 0:05 ` Jingoo Han
[not found] ` <009301cf93f6$f938a270$eba9e750$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-07-01 18:25 ` Rickard Strandqvist
2014-07-01 18:25 ` Rickard Strandqvist
[not found] ` <CAFo99gY2qEEqwJgu-NQryAe2=o5AsDjL+SFaau6BA7CBMH8Xkg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-03 1:45 ` Jingoo Han
2014-07-03 1:45 ` Jingoo Han
[not found] ` <003601cf9660$83368990$89a39cb0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-07-03 8:41 ` Wolfram Sang [this message]
2014-07-03 8:41 ` Wolfram Sang
2014-07-03 19:46 ` Rickard Strandqvist
2014-07-03 19:46 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140703084108.GA3012@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=peter-+2lRwdCCLRT2eFz/2MeuCQ@public.gmane.org \
--cc=rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=shangll-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.