All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Krzysztof Kozlowski
	<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Dmitry Eremin-Solenikov
	<dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Kyungmin Park
	<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Marek Szyprowski
	<m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Bartlomiej Zolnierkiewicz
	<b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document
Date: Thu, 3 Jul 2014 12:32:36 +0100	[thread overview]
Message-ID: <20140703113236.GA28504@leverpostej> (raw)
In-Reply-To: <1404198121-22989-6-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Hi,

On Tue, Jul 01, 2014 at 08:02:00AM +0100, Krzysztof Kozlowski wrote:
> Add document describing device tree bindings for MAX14577 MFD
> drivers: MFD core, extcon, regulator and charger.
> 
> Both MAX14577 and MAX77836 chipsets are documented.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
> Cc: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Reviewed-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++++++++++++
>  1 file changed, 152 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt
> new file mode 100644
> index 000000000000..b235250a7b41
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/max14577.txt
> @@ -0,0 +1,152 @@
> +Maxim MAX14577/77836 Multi-Function Device
> +
> +MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+
> +Battery Charger and SFOUT LDO output for powering USB devices. It is
> +interfaced to host controller using I2C.
> +
> +MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge.
> +
> +
> +Required properties:
> +- compatible : Must be "maxim,max14577" or "maxim,max77836".
> +- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836)
> +- interrupts : IRQ line for the chip.
> +- interrupt-parent :  The parent interrupt controller.
> +
> +
> +Required nodes:
> + - charger :
> +	Node for configuring the charger driver.
> +	Required properties:
> +		- compatible : "maxim,max14577-charger"
> +			or "maxim,max77836-charger"
> +		- maxim,fast-charge-timer : Timer in hours to trigger the
> +			INT3/MBCCHGERR interrupt; Valid values:
> +			- 5, 6 or 7 (hours),
> +			- 0 to disable.

I'm not sure I follow what this is any why it should be in the DT.

Could you explain what this is used for?

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <Pawel.Moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Tomasz Figa <t.figa@samsung.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document
Date: Thu, 3 Jul 2014 12:32:36 +0100	[thread overview]
Message-ID: <20140703113236.GA28504@leverpostej> (raw)
In-Reply-To: <1404198121-22989-6-git-send-email-k.kozlowski@samsung.com>

Hi,

On Tue, Jul 01, 2014 at 08:02:00AM +0100, Krzysztof Kozlowski wrote:
> Add document describing device tree bindings for MAX14577 MFD
> drivers: MFD core, extcon, regulator and charger.
> 
> Both MAX14577 and MAX77836 chipsets are documented.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Tomasz Figa <t.figa@samsung.com>
> Cc: devicetree@vger.kernel.org
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> ---
>  Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++++++++++++
>  1 file changed, 152 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt
> new file mode 100644
> index 000000000000..b235250a7b41
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/max14577.txt
> @@ -0,0 +1,152 @@
> +Maxim MAX14577/77836 Multi-Function Device
> +
> +MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+
> +Battery Charger and SFOUT LDO output for powering USB devices. It is
> +interfaced to host controller using I2C.
> +
> +MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge.
> +
> +
> +Required properties:
> +- compatible : Must be "maxim,max14577" or "maxim,max77836".
> +- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836)
> +- interrupts : IRQ line for the chip.
> +- interrupt-parent :  The parent interrupt controller.
> +
> +
> +Required nodes:
> + - charger :
> +	Node for configuring the charger driver.
> +	Required properties:
> +		- compatible : "maxim,max14577-charger"
> +			or "maxim,max77836-charger"
> +		- maxim,fast-charge-timer : Timer in hours to trigger the
> +			INT3/MBCCHGERR interrupt; Valid values:
> +			- 5, 6 or 7 (hours),
> +			- 0 to disable.

I'm not sure I follow what this is any why it should be in the DT.

Could you explain what this is used for?

Thanks,
Mark.

  parent reply	other threads:[~2014-07-03 11:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01  7:01 [RESEND PATCH 0/5] charger/mfd: max14577: Add support for MAX77836 Krzysztof Kozlowski
2014-07-01  7:01 ` [RESEND PATCH 1/5] charger: max14577: Add support for MAX77836 charger Krzysztof Kozlowski
2014-07-01  7:01 ` [RESEND PATCH 2/5] regulator/mfd: max14577: Export symbols for calculating charger current Krzysztof Kozlowski
2014-07-01  7:01 ` [RESEND PATCH 3/5] charger: max14577: Configure battery-dependent settings from DTS Krzysztof Kozlowski
2014-07-03 11:36   ` Mark Rutland
2014-07-03 11:45     ` Krzysztof Kozlowski
2014-07-01  7:01 ` [RESEND PATCH 4/5] power: max17040: Add ID for MAX77836 Fuel Gauge block Krzysztof Kozlowski
     [not found] ` <1404198121-22989-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-07-01  7:02   ` [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
2014-07-01  7:02     ` Krzysztof Kozlowski
     [not found]     ` <1404198121-22989-6-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-07-03 11:32       ` Mark Rutland [this message]
2014-07-03 11:32         ` Mark Rutland
2014-07-03 11:44         ` Krzysztof Kozlowski
2014-07-03 11:44           ` Krzysztof Kozlowski
2014-07-04  8:07           ` Mark Rutland
2014-07-04  8:07             ` Mark Rutland
2014-07-04  8:13             ` Krzysztof Kozlowski
2014-07-04  8:13               ` Krzysztof Kozlowski
2014-07-01  7:40 ` [RESEND PATCH 0/5] charger/mfd: max14577: Add support for MAX77836 Lee Jones
  -- strict thread matches above, loose matches on Subject: below --
2014-05-26  7:47 [RESEND PATCH 0/5] charger/mfd: max14577: Part 2 of adding " Krzysztof Kozlowski
2014-05-26  7:47 ` [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140703113236.GA28504@leverpostej \
    --to=mark.rutland-5wv7dgnigg8@public.gmane.org \
    --cc=Pawel.Moll-5wv7dgnIgG8@public.gmane.org \
    --cc=b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.