Re: [PATCH v10 1/3] arm64: Add __NR_* definitions for compat syscalls

[Catalin Marinas <catalin.marinas@arm.com>]

On Fri, Jul 04, 2014 at 11:06:07AM +0100, Arnd Bergmann wrote:
> On Friday 04 July 2014 16:28:29 AKASHI Takahiro wrote:
> > From: Catalin Marinas <catalin.marinas@arm.com>
> > 
> > This patch adds __NR_* definitions to asm/unistd32.h, moves the
> > __NR_compat_* definitions to asm/unistd.h and removes all the explicit
> > unistd32.h includes apart from the one building the compat syscall
> > table. The aim is to have the compat __NR_* definitions available but
> > without colliding with the native syscall definitions.
> > 
> > And adds more syscall definitions for 3.16.
> 
> Can you explain in more detail why you want to add those macros? I've
> looked at all three patches in the series but can't find any code using
> them.
> 
> I would expect that we don't need to define those macros at all for
> compat mode, since they are meant primarily for user space (glibc)
> compilation, which gets them from arch/arm/include/asm/unistd.h.

That's coming from commit 4b58841149dc (audit: Add generic compat
syscall support). The compat_audit.c code reuses some of the existing
asm-generic/audit_*.h headers which depend on __NR_* definitions (rather
than __NR_COMPAT_*). Akashi's suggestion was to include a unistd32.h,
hence this patch.

-- 
Catalin